Merge rc/1.19 into master

[asger-semmle]

Merges the right child of #503 and #561 into master.

[adityasharad]

At this point we should not be merging 1.19 into master, but into next.

[asger-semmle]

Ah, that explains it. Thanks.

[pavgust]

This pull request introduces 160 alerts when merging 20ffdf4 into a4b3b1e - view on LGTM.com

new alerts:

• 25 for Syntax error
• 13 for Unused import
• 12 for Variable defined multiple times
• 9 for First argument of a method is not named 'self'
• 8 for Statement has no effect
• 4 for Empty except
• 4 for Unused local variable
• 4 for Missing call to __init__ during object initialization
• 3 for Use of the return value of a procedure
• 3 for First argument to super() is not enclosing class
• 2 for Multiple calls to __init__ during object initialization
• 2 for Unused named argument in formatting call
• 2 for Except block handles 'BaseException'
• 2 for Illegal raise
• 2 for Overwriting attribute in super-class or sub-class
• 2 for Explicit returns mixed with implicit (fall through) returns
• 2 for Implicit string concatenation in a list
• 2 for Multiple calls to __del__ during object destruction
• 2 for Wrong number of arguments in a call
• 2 for Wrong number of arguments in a class instantiation
• 2 for File is not always closed
• 1 for __iter__ method returns a non-iterator
• 1 for Too few arguments in formatting call
• 1 for Membership test with a non-container
• 1 for Inconsistent method resolution order
• 1 for Unmatchable dollar in regular expression
• 1 for Non-exception in 'except' clause
• 1 for Unmatchable caret in regular expression
• 1 for Mutation of descriptor in __get__ or __set__ method.
• 1 for Wrong name for an argument in a call
• 1 for Formatted object is not a mapping
• 1 for Mismatch in multiple assignment
• 1 for Commented out code
• 1 for Unsupported format character
• 1 for Unreachable 'except' block
• 1 for Duplication in regular expression character class
• 1 for Comparison using is when operands support __eq__
• 1 for Missing named arguments in formatting call
• 1 for Non-callable called
• 1 for Special method has incorrect signature
• 1 for Maybe missing 'self' in comparison
• 1 for Missing call to __del__ during object destruction
• 1 for Iterable can be either a string or a sequence
• 1 for Formatting string mixes implicitly and explicitly numbered fields
• 1 for Superclass attribute shadows subclass method
• 1 for Unnecessary 'else' clause in loop
• 1 for First parameter of a class method is not named 'cls'
• 1 for __init__ method is a generator
• 1 for Missing part of special group in regular expression
• 1 for Unused argument in a formatting call
• 1 for Comparison of identical values
• 1 for Unreachable code
• 1 for Incomplete ordering
• 1 for Explicit export is not defined
• 1 for Wrong number of arguments for format
• 1 for Backspace escape in regular expression
• 1 for __del__ is called explicitly
• 1 for NotImplemented is not an Exception
• 1 for Module is imported with 'import' and 'import from'
• 1 for Redundant assignment
• 1 for Importing value of mutable attribute
• 1 for __init__ method returns a value
• 1 for Nested loops with same variable
• 1 for Information exposure through an exception
• 1 for Hard-coded credentials
• 1 for Wrong name for an argument in a class instantiation
• 1 for Nested loops with same variable reused after inner loop body
• 1 for Returning tuples with varying lengths
• 1 for Unnecessary delete statement in function
• 1 for URL redirection from remote source
• 1 for Unused exception object
• 1 for Unguarded next in generator
• 1 for Modification of dictionary returned by locals()
• 1 for __init__ method calls overridden method

---

Comment posted by LGTM.com