PullSubscription and Storage importer metrics

[nachocano]

• Adding event_count metrics to PullSubscription and Storage.
• Commenting out current observability pattern. I think we can do a proper refactor if we think that is the right way to go later on.
• The service account the receive adapter is running on needs to have roles/monitoring.metricWriter permissions to use the SD monitoring APIs... Example to set it up:

gcloud projects add-iam-policy-binding $PROJECT_ID \
  --member=serviceAccount:cloudrunevents-pullsub@$PROJECT_ID.iam.gserviceaccount.com \
  --role roles/monitoring.metricWriter

[knative-prow-robot]

Hi @nachocano. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[n3wscott]

/ok-to-test

[nachocano]

need to wait until knative/pkg#648 and knative/pkg#656 are merged, otherwise it doesn't compile...

[n3wscott]

this should fix your deps issues: #254

[nachocano]

@n3wscott ready for another look...

[nachocano]

@n3wscott any idea of what can be wrong with the e2e here?

[nachocano]

/test pull-google-knative-gcp-integration-tests

[nachocano]

e2e tests are failing due to a bug that this PR will solve. Will update the CloudEvents SDK version then, and give it another try

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pubsub/adapter/adapter.go	67.9%	57.1%	-10.8
pkg/pubsub/adapter/observability.go	43.8%	0.0%	-43.8
pkg/reconciler/pullsubscription/pullsubscription.go	68.0%	67.9%	-0.0

[knative-prow-robot]

@nachocano: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-google-knative-gcp-go-coverage	b15a2fa	link	/test pull-google-knative-gcp-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[n3wscott]

/lgtm
/approve

THANKS!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nachocano]

/lgtm
/approve

THANKS!

THANK YOU!!!