Skip to content

Initial StatsReporter for Source #648

Merged
knative-prow-robot merged 17 commits into
knative:masterfrom
nachocano:source_stats
Sep 10, 2019
Merged

Initial StatsReporter for Source #648
knative-prow-robot merged 17 commits into
knative:masterfrom
nachocano:source_stats

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Sep 9, 2019 •
edited
Loading

  • Adding a source_stats_reporter within metrics package. As with the source duck type, eventing sources might not want to depend on eventing to construct a source/importer. Thus, we are adding a source reporter herein. Note the name is source instead of importer, to match the duck type. Label tags are importer though. We may need to change them later on..

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 9, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Sep 9, 2019

/assign @yanweiguo
/assign @n3wscott

fyi @sayanh, @Harwayne

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Sep 9, 2019

/test pull-knative-pkg-unit-tests

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Sep 9, 2019

/hold until we remove the base64 stuff

yanweiguo
yanweiguo reviewed Sep 9, 2019
View reviewed changes
Comment thread logging/config.go Outdated
Comment thread metrics/source_stats_reporter.go
mattmoor-sockpuppet
mattmoor-sockpuppet reviewed Sep 9, 2019
View reviewed changes
Comment thread metrics/config_test.go Outdated
nachocano
nachocano commented Sep 9, 2019
View reviewed changes
Comment thread metrics/config_test.go Outdated
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2019
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Sep 10, 2019

I would break this into at least 2 PRs.

n3wscott
n3wscott reviewed Sep 10, 2019
View reviewed changes
Comment thread metrics/config_test.go Outdated
@nachocano nachocano mentioned this pull request Sep 10, 2019
Merged
@nachocano nachocano changed the title Common metrics/logging constructs for eventing sources Initial StatsReporter for Source Sep 10, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Sep 10, 2019

/hold cancel

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Sep 10, 2019

@n3wscott splitted in this one and #656
ready for another look

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Sep 10, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
metrics/source_stats_reporter.go Do not exist 0.0%
metrics/utils.go Do not exist 0.0%

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 10, 2019

@nachocano: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-pkg-go-coverage a3a69c4 link /test pull-knative-pkg-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yanweiguo
Copy link
Copy Markdown
Contributor

yanweiguo commented Sep 10, 2019

/lgtm

I'll approve if @n3wscott has no more comments.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@nachocano nachocano mentioned this pull request Sep 10, 2019
Merged
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Sep 10, 2019

synced offline with @n3wscott and he is willing to accept this. Let's wait to hear from him here, and we are good to go... thanks @yanweiguo

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Sep 10, 2019

/lgtm

@yanweiguo
Copy link
Copy Markdown
Contributor

yanweiguo commented Sep 10, 2019

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2019
@knative-prow-robot knative-prow-robot merged commit b2eb686 into knative:master Sep 10, 2019
@nachocano nachocano mentioned this pull request Sep 11, 2019
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

3 more reviewers

@yanweiguo yanweiguo yanweiguo left review comments

@n3wscott n3wscott n3wscott left review comments

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yanweiguo yanweiguo

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nachocano @n3wscott @knative-metrics-robot @knative-prow-robot @yanweiguo @mattmoor-sockpuppet @googlebot