Serializing/Deserializing Logging and Metrics configs#656
Merged
Conversation
Contributor
nachocano
commented
Sep 10, 2019
nachocano
commented
- Moving to pkg a way to serialize/deserialize logging and metric configMaps. This is a modified version of the code written by @n3wscott here, but as will be used in many places, we are moving it down to pkg.
knative-prow-robot
added
the
size/L
Contributor
Author
|
/assign @n3wscott |
|
The following is the coverage report on pkg/.
|
This was referenced Sep 10, 2019
Contributor
|
/lgtm |
Contributor
Author
|
@yanweiguo this one is ready for approval. I think @n3wscott doesn't have approval in these folder |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.