Easy go-jose updates (the codeless[ish] ones)#28140
Merged
Merged
Conversation
github-actions
Bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
maithyton
approved these changes
Aug 21, 2024
mdgreenfield
added a commit
to mdgreenfield/vault-plugin-secrets-kv
that referenced
this pull request
Jan 24, 2025
Also upgrades the go version to 1.23.3 due to: ``` $ go mod tidy -go=1.21 go: github.com/hashicorp/vault/sdk@v0.14.1 requires go@1.23.3, but 1.21 is requested ``` This change addresses switching `google/tink-go` to `tink-crypto/tink-go` to address the `square/go-jose` switch to `go-jose/go-jose`. See hashicorp/vault#28140
VioletHynes
pushed a commit
to hashicorp/vault-plugin-secrets-kv
that referenced
this pull request
Jan 24, 2025
Also upgrades the go version to 1.23.3 due to: ``` $ go mod tidy -go=1.21 go: github.com/hashicorp/vault/sdk@v0.14.1 requires go@1.23.3, but 1.21 is requested ``` This change addresses switching `google/tink-go` to `tink-crypto/tink-go` to address the `square/go-jose` switch to `go-jose/go-jose`. See hashicorp/vault#28140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the (mostly) codeless changes required to remove our dependency on vulnerable versions of
go-jose(before v2.6.3, v3.0.3, or v4.0.1)There is one transitive hashicorp-controlled dependency on an old
go-jose, at hashicorp/vault-testing-stepwise. A PR for this has been merged, but updating here is waiting on a docker issue, sincevault-testing-stepwiseupdated docker inv.0.2.0.The most invasive change included here is on
google/tink-go, which went through a few 'organizational' changes since we updated it. To get to a non-vulnerable version, I had to move us to the new import pathtink-crypto/tink-go. This isn't the latest path, but rather the nearest equivalent to what we were using that didn't depend on a "bad"go-jose.