Backport of Easy go-jose updates (the codeless[ish] ones) into release/1.17.x#28146
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
CI Results: |
|
Build Results: |
|
In addition to the Okta issue, there are two remaining dependencies on old jose that are "stuck" - vault -> docker 25.0.6 -> containerd 1.7.12 -> jose 2.5.1, and vault -> vault-testing-stepwise -> docker 25.0.6 (see hashicorp/go-secure-stdlib#132) Due to the linked issue, these are left for a future update (possibly along with the aforementioned Okta?) |
…ges/kindly-ace-crab
|
The fixed version of this backport has merged: #28152, so I'm closing this. |
Backport
This PR is auto-generated from #28140 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
🚨
The person who merged in the original PR is:
@kpcraig
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
These are the (mostly) codeless changes required to remove our dependency on vulnerable versions of
go-jose(before v2.6.3, v3.0.3, or v4.0.1)There is one transitive hashicorp-controlled dependency on an old
go-jose, at hashicorp/vault-testing-stepwise. A PR for this has been merged, but updating here is waiting on a docker issue, sincevault-testing-stepwiseupdated docker inv.0.2.0.The most invasive change included here is on
google/tink-go, which went through a few 'organizational' changes since we updated it. To get to a non-vulnerable version, I had to move us to the new import pathtink-crypto/tink-go. This isn't the latest path, but rather the nearest equivalent to what we were using that didn't depend on a "bad"go-jose.Overview of commits