Skip to content

Manual backport of "Easy go-jose updates"#28152

Merged
kpcraig merged 1 commit into
release/1.17.xfrom
backport/VAULT-28868/codeless-changes/manual
Aug 22, 2024
Merged

Manual backport of "Easy go-jose updates"#28152
kpcraig merged 1 commit into
release/1.17.xfrom
backport/VAULT-28868/codeless-changes/manual

Conversation

@kpcraig
Copy link
Copy Markdown
Contributor

@kpcraig kpcraig commented Aug 22, 2024

This is the manually created version of #28146, because things are being a bit squirrely.

That PR itself stems from the main PR of: #28140

I left the following comment in the other thread:

In addition to the Okta issue, there are two remaining dependencies on old jose that are "stuck" - vault -> docker 25.0.6 -> containerd 1.7.12 -> jose 2.5.1, and vault -> vault-testing-stepwise -> docker 25.0.6 (see hashicorp/go-secure-stdlib#132)

Due to the linked issue, these are left for a future update (possibly along with the aforementioned Okta?)

@kpcraig kpcraig requested review from a team as code owners August 22, 2024 15:10
@kpcraig kpcraig changed the base branch from main to release/1.17.x August 22, 2024 15:10
@kpcraig kpcraig changed the title Backport of "Easy go-jose updates" Manual backport of "Easy go-jose updates" Aug 22, 2024
@kpcraig kpcraig marked this pull request as draft August 22, 2024 15:17
@kpcraig kpcraig marked this pull request as ready for review August 22, 2024 15:17
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@kpcraig kpcraig merged commit d372cc8 into release/1.17.x Aug 22, 2024
@kpcraig kpcraig deleted the backport/VAULT-28868/codeless-changes/manual branch August 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants