Skip to content

add tencentcloudkms server seal#8855

Closed
likexian wants to merge 1 commit into
hashicorp:masterfrom
tencentyun:tencentcloudkms
Closed

add tencentcloudkms server seal#8855
likexian wants to merge 1 commit into
hashicorp:masterfrom
tencentyun:tencentcloudkms

Conversation

@likexian
Copy link
Copy Markdown

Hello,

This PR add TencentCloud KMS as one of the method of server seal.

I have test it and it works.

Please have a review, thank you.

Copy link
Copy Markdown
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a disapproval here to note that this should be blocked by #8362

Once that's merged it should be redone along those lines.

@pbernal
Copy link
Copy Markdown
Contributor

pbernal commented Jun 12, 2020

@likexian - FYI, jeff's configutil branch was merged, and you should be able to make updates for your PR.

@likexian
Copy link
Copy Markdown
Author

Hello @jefferai @pbernal
This is a big changes and there are so many conflictings that I have do a new fork and make a new PR, please redirect to: #9253
Please help processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants