test: remove top-level code in test-indexing.R#1085
Merged
aviator-app[bot] merged 5 commits intomainfrom Jan 16, 2024
Merged
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
Contributor
Author
3 tasks
Member
|
I'm not sure what these names are referring to. |
maelle
commented
Jan 8, 2024
maelle
commented
Jan 8, 2024
maelle
force-pushed
the
refactor-indexing-test
branch
from
c4992aa to
ed98ece
Compare
szhorvat
approved these changes
Jan 15, 2024
maelle
force-pushed
the
refactor-indexing-test
branch
from
ed98ece to
77a98ca
Compare
aviator-app
Bot
force-pushed
the
refactor-indexing-test
branch
from
77a98ca to
7e19c99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@szhorvat if
am()andmm()had longer names, what would those be? I'd like to replace them with longer, more informative names.Removing top-level code in test files help make each test more self-contained, therefore easier to re-run interactively when it fails (as happens in #1080)
Part of #1082