Skip to content

wasm: delete unused code.#3404

Merged
istio-testing merged 1 commit intoistio:masterfrom
mathetake:delete-wasm-unused
Jul 11, 2021
Merged

wasm: delete unused code.#3404
istio-testing merged 1 commit intoistio:masterfrom
mathetake:delete-wasm-unused

Conversation

@mathetake
Copy link
Copy Markdown
Member

Wasm is already upstreamed to Envoy and this PR removes the unused codes from here. Notably this removes IstioContext, IstioWasm and thus the factory overrides over EnvoyWasm class.
Ref: envoyproxy/envoy#17268

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 11, 2021
@istio-policy-bot
Copy link
Copy Markdown

😊 Welcome @mathetake! This is either your first contribution to the Istio proxy repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla Bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 11, 2021
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Jul 11, 2021
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @mathetake. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mathetake mathetake marked this pull request as ready for review July 11, 2021 02:28
@mathetake mathetake requested a review from a team July 11, 2021 02:28
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 11, 2021
@mathetake
Copy link
Copy Markdown
Member Author

cc @PiotrSikora

@bianpengyuan
Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 11, 2021
@bianpengyuan
Copy link
Copy Markdown
Contributor

/retest

@istio-testing istio-testing merged commit 86eb99a into istio:master Jul 11, 2021
@mathetake mathetake deleted the delete-wasm-unused branch July 11, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants