Update Envoy SHA to 09-13.#3493
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
google-cla
Bot
added
the
cla: yes
istio-testing
added
the
size/M
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
Looks like the stackdriver plugin is implicitly relying on the past Envoy's behavior of prefixing all the metrics with "envoy_" .. need to make change to the plugin so that it explicitly prefixes with "envoy_". |
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
istio-testing
added
size/L
| Metric export_call(MetricType::Counter, "envoy_export_call", | ||
| {MetricTag{"wasm_filter", MetricTag::TagType::String}, | ||
| MetricTag{"type", MetricTag::TagType::String}, | ||
| MetricTag{"success", MetricTag::TagType::Bool}}); |
There was a problem hiding this comment.
Yeah we occasionally use this to debug that stackdriver export call is made or not.
|
/retest |
|
@mathetake actually, curious how do we generate istio stats with |
|
The "istio" prefix has already been added at extensions side: proxy/extensions/stats/plugin.h Line 55 in e02cbbe so we don't need to modify that. Previously what we have done so far is that using registerPrometheusNamespace in the Envoy codebase to register "istio" statically, and make Envoy opt-out "istio**" metrics in the prometheus endpoint, meaning Envoy doesn't append "envoy_" prefix to these "istio" prefixed metrics when they are exposed in /stats/prometheus.
The change in envoyproxy/envoy#17357 removed the need for registerPrometheusNamespace and made the prometheus stat endpoint (/stats/prometheus) expose all the Wasm-program-defined metrics as-is. That means, not only "istio_**" metrics but also any other user-defined custom metrics are exposed in the /stats/prometheus without being modified (which is great for all the Wasm extension users!). |
|
I see, thanks for detailed explanation! @mathetake |
3 participants
Thanks to envoyproxy/envoy#17357, registerPrometheusNamespace has been deleted and we no longer need to statically register prometheus stat namespaces. Not only that, this also resolves istio/istio#27635 since the change in Envoy is handling any stat namespaces transparently to users and therefore users are free to determine the namespace they want to use in their own metrics exposed by Wasm plugins.
This completes the refactoring for removing all the Istio specific Wasm code base in Envoy (i.e. C++ code under src/**) combined with #3413 #3404 envoyproxy/envoy#17268