Skip to content

wasm: remove unused Istio specific Wasm code under src.#3413

Merged
istio-testing merged 10 commits intoistio:masterfrom
mathetake:wasm-unused
Jul 15, 2021
Merged

wasm: remove unused Istio specific Wasm code under src.#3413
istio-testing merged 10 commits intoistio:masterfrom
mathetake:wasm-unused

Conversation

@mathetake
Copy link
Copy Markdown
Member

@mathetake mathetake commented Jul 15, 2021

Combined with #3404, this PR removes unused Istio specific Wasm extension code under src. Necessary change per envoyproxy/envoy#17268.

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake requested review from a team July 15, 2021 00:33
@google-cla google-cla Bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 15, 2021
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2021
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @mathetake. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bianpengyuan
Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 15, 2021
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Copy link
Copy Markdown
Member Author

OK I found that the IstioExtension class calls registerPrometheusNamespace("istio"); in its constructor so we have to do it somewhere. This is related to envoyproxy/envoy#14920 istio/istio#27635 and maybe we should support that via foregin functions.

This reverts commit 95672d2.
This reverts commit 0d9539d.
This reverts commit 8f4daed.
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Copy link
Copy Markdown
Member Author

so for now, leave the namespace registration as-is, will come back to this after I fixed envoyproxy/envoy#14920

@mathetake
Copy link
Copy Markdown
Member Author

/retest

@istio-testing istio-testing merged commit 1cb6d0f into istio:master Jul 15, 2021
@mathetake mathetake deleted the wasm-unused branch July 15, 2021 06:23
@mathetake
Copy link
Copy Markdown
Member Author

fyi: created a patch envoyproxy/envoy#17357 to allow plugins to register namespaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants