fix: guard getUserMedia call against undefined mediaDevices in non-secure contexts#78
Merged
jamiepine merged 1 commit intojamiepine:mainfrom Feb 23, 2026
Conversation
Copilot AI
added a commit
to Patrick-DE/voicebox
that referenced
this pull request
Feb 19, 2026
…ne#88, jamiepine#91, jamiepine#95, jamiepine#97) Co-authored-by: Patrick-DE <14962702+Patrick-DE@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigator.mediaDevicesandnavigator.mediaDevices.getUserMediabefore attempting to access the microphone inAudioSampleRecording.tsxCannot read properties of undefined (reading 'getUserMedia')) that occurs in non-secure (HTTP) contexts wherenavigator.mediaDevicesisundefinedRoot cause
navigator.mediaDevicesis only available in secure contexts (HTTPS or localhost). On plain HTTP, it isundefined. The cleanup effect unconditionally called.getUserMedia(...)on mount, causing an unhandled exception when the component unmounted — even if the user never interacted with the record tab.Fix
useEffect(() => { if (!showWaveform) return; + if (!navigator.mediaDevices || !navigator.mediaDevices.getUserMedia) return;Credit
Bug found and fix identified by AuroraSkye on the Voicebox Discord. Thank you!