fix: pass language parameter to TTS models#97
Open
jannone wants to merge 1 commit intojamiepine:mainfrom
Open
Conversation
The language parameter was accepted by both backends' generate() methods but never forwarded to the underlying TTS models. This caused the model to default to "Auto" language detection, which frequently confused Portuguese for Spanish due to lexical similarity. - Add LANGUAGE_CODE_TO_NAME mapping (ISO 639-1 → full name) to both PyTorch and MLX backends, matching what Qwen3-TTS expects - Pass language to generate_voice_clone() in PyTorch backend - Pass lang_code to all model.generate() call sites in MLX backend - Auto-sync generation form language dropdown with selected voice profile's language in FloatingGenerateBox Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI
added a commit
to Patrick-DE/voicebox
that referenced
this pull request
Feb 19, 2026
…ne#88, jamiepine#91, jamiepine#95, jamiepine#97) Co-authored-by: Patrick-DE <14962702+Patrick-DE@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
languageparameter — it was accepted bygenerate()but never forwarded to the underlying Qwen3-TTS model, causing it to default to "Auto" detection which frequently confuses Portuguese for SpanishLANGUAGE_CODE_TO_NAMEmapping (ISO 639-1 → full language name) to both PyTorch and MLX backends, matching the format Qwen3-TTS expects (e.g."pt"→"portuguese")language=togenerate_voice_clone()lang_code=to all 4model.generate()call sitesuseEffectTest plan
🤖 Generated with Claude Code