Fix: selecting 0.6B model still downloads and uses 1.7B#95
Merged
jamiepine merged 2 commits intojamiepine:mainfrom Feb 23, 2026
Merged
Conversation
The /generate endpoint created the voice prompt before loading the user's requested model size. Since create_voice_prompt() internally calls load_model_async(None), it fell back to the hardcoded default of "1.7B", causing the 1.7B model to be downloaded even when the user explicitly selected 0.6B. This reorders the operations so the requested model is loaded first, ensuring create_voice_prompt() and generate() use the correct model. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI
added a commit
to Patrick-DE/voicebox
that referenced
this pull request
Feb 19, 2026
…ne#88, jamiepine#91, jamiepine#95, jamiepine#97) Co-authored-by: Patrick-DE <14962702+Patrick-DE@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/generateendpoint was creating the voice prompt before loading the user's requested model sizecreate_voice_prompt()internally callsload_model_async(None), it fell back to the hardcoded default of"1.7B", causing the 1.7B model to be downloaded even when the user explicitly selected 0.6Bload_model_async(model_size)is called beforecreate_voice_prompt_for_profile(), ensuring the correct model is loaded firstSteps to reproduce
Test plan
🤖 Generated with Claude Code