Skip to content

[VERY DRAFT] Dima's hacks#1097

Closed
dimaqq wants to merge 29 commits intojuju:mainfrom
dimaqq:dima-hack
Closed

[VERY DRAFT] Dima's hacks#1097
dimaqq wants to merge 29 commits intojuju:mainfrom
dimaqq:dima-hack

Conversation

@dimaqq
Copy link
Copy Markdown
Contributor

@dimaqq dimaqq commented Aug 30, 2024

No description provided.

@jujubot
Copy link
Copy Markdown
Contributor

jujubot commented Aug 30, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

1 similar comment
@jujubot
Copy link
Copy Markdown
Contributor

jujubot commented Aug 30, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

'type': 'object'},
'CharmContainer': {'additionalProperties': False,
'properties': {'mounts': {'items': {'$ref': '#/definitions/CharmMount'},
'properties': {'gid': {'type': 'integer'},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow adding client20 updated all the other clients, like client1 here.

I'm not sure what's going on, should these changes be pulled in or not?

@dimaqq
Copy link
Copy Markdown
Contributor Author

dimaqq commented Nov 15, 2024

Type hints moved to #1189

@dimaqq dimaqq closed this Nov 15, 2024
@dimaqq dimaqq deleted the dima-hack branch November 15, 2024 07:34
jujubot added a commit that referenced this pull request Nov 19, 2024
#1189

Pull the Connection type hints from #1097

Only minor cleanup beyond that, no logical changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants