chore: type hints for the connnection class#1189
Merged
Conversation
dimaqq
force-pushed
the
chore-connnection-types
branch
from
ae6f49c to
1a23a60
Compare
dimaqq
changed the title
james-garner-canonical
requested changes
Nov 18, 2024
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Sorry, I made a lot of comments. You can resolve most without any changes, but I think it would be nice to use something a bit more readable for the for ... else one.
james-garner-canonical
approved these changes
Nov 19, 2024
Contributor
Author
|
/merge |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull the Connection type hints from #1097
Only minor cleanup beyond that, no logical changes.