Fix for test flake when sync waiting and an intermediate error occurs#1052
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Oct 8, 2020
Merged
Fix for test flake when sync waiting and an intermediate error occurs#1052knative-prow-robot merged 2 commits intoknative:masterfrom
knative-prow-robot merged 2 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
approved
mattmoor
reviewed
Oct 7, 2020
Member
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
Contributor
Author
|
/test pull-knative-client-integration-tests |
knative-prow-robot
added
size/S
Contributor
Author
|
/test pull-knative-client-integration-tests |
1 similar comment
Contributor
Author
|
/test pull-knative-client-integration-tests |
knative-prow-robot
added
the
ok-to-test
Contributor
Author
|
/test pull-knative-client-integration-tests |
knative-prow-robot
added
size/M
rhuss
changed the title
|
The following is the coverage report on the affected files.
|
Contributor
|
Thanks @rhuss for the thorough analysis and fix. IMO it looks good, but lets wait for other reviewers. /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, maximilien, navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
navidshaikh
pushed a commit
to navidshaikh/client
that referenced
this pull request
Oct 9, 2020
…knative#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added
navidshaikh
pushed a commit
to navidshaikh/client
that referenced
this pull request
Oct 12, 2020
…knative#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added
navidshaikh
added
the
backport/candidate
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix for test flake when sync waiting and an intermediate error occurs (#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added * Add WithLabel list filter to serving client lib (#1054) * add WithLabel list filter Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * adding tests Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * update changelog Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * Update CHANGELOG Co-authored-by: Roland Huß <roland@ro14nd.de> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix for test flake when sync waiting and an intermediate error occurs (#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added * Add WithLabel list filter to serving client lib (#1054) * add WithLabel list filter Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * adding tests Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * update changelog Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * Update CHANGELOG Co-authored-by: Roland Huß <roland@ro14nd.de> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
navidshaikh
added
backported-to/0.17
and removed
backport/candidate
rhuss
added a commit
to rhuss/knative-client
that referenced
this pull request
Oct 12, 2020
…knative#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix workaround the issue as described in knative/serving#9727 but is useful in general to cancel an error window if a non-error condition event is received.