Add WithLabel list filter to serving client lib by zroubalik · Pull Request #1054 · knative/client

zroubalik · 2020-10-08T11:38:07Z

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Description

Adding WithLabel list filter to serving client lib, which is missing currently. This allows to filter lists by labels.

Reference

Fixes #1053

/lint

knative-prow-robot

@zroubalik: 1 warning.

Details

In response to this:

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Description

Adding WithLabel list filter to serving client lib, which is missing currently. This allows to filter lists by labels.

Reference

Fixes #1053

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2020-10-08T11:38:20Z

Welcome @zroubalik! It looks like this is your first PR to knative/client 🎉

knative-prow-robot · 2020-10-08T11:38:20Z

Hi @zroubalik. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

navidshaikh

/ok-to-test

rhuss

Thanks ! Looks good, but could you please also add a test to client_test_mock.go and client_test.go ?

Also an entry in CHANGELOG.adoc would be cool

maximilien

Thanks for contributions. Any way to add tests and show how to use this?

zroubalik · 2020-10-09T08:54:24Z

I have added tests. Let me know if I should add anything else.

navidshaikh

lgtm, thanks @zroubalik ! can you please finalize the PR with a changelog entry in CHANGELOG.adoc ?

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

zroubalik · 2020-10-09T10:59:41Z

@navidshaikh Changelog updated, let me know if you need anything else, thanks!

knative-metrics-robot · 2020-10-09T11:03:04Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/serving/v1/client.go	66.5%	66.8%	0.4

zroubalik · 2020-10-09T11:25:33Z

/retest

navidshaikh

/lgtm
/approve

thanks @zroubalik for contribution, keep them coming! ;-)

knative-prow-robot · 2020-10-09T13:49:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* add WithLabel list filter Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * adding tests Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * update changelog Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* Fix for test flake when sync waiting and an intermediate error occurs (#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added * Add WithLabel list filter to serving client lib (#1054) * add WithLabel list filter Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * adding tests Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * update changelog Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * Update CHANGELOG Co-authored-by: Roland Huß <roland@ro14nd.de> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>

* add WithLabel list filter Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * adding tests Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * update changelog Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2020

knative-prow-robot requested review from rhuss and sixolet October 8, 2020 11:38

knative-prow-robot reviewed Oct 8, 2020

View reviewed changes

Comment thread pkg/serving/v1/client.go Outdated

knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2020

zroubalik force-pushed the withlabel branch from 0b9b3c0 to c1811fe Compare October 8, 2020 11:39

zroubalik requested a review from knative-prow-robot October 8, 2020 11:40

zroubalik mentioned this pull request Oct 8, 2020

Use knative client lib knative/func#160

Closed

navidshaikh approved these changes Oct 8, 2020

View reviewed changes

rhuss suggested changes Oct 8, 2020

View reviewed changes

maximilien suggested changes Oct 9, 2020

View reviewed changes

knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2020

navidshaikh approved these changes Oct 9, 2020

View reviewed changes

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020

Zbynek Roubalik added 3 commits October 9, 2020 12:57

add WithLabel list filter

394823b

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

adding tests

462bb5b

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

update changelog

ecb559e

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

zroubalik force-pushed the withlabel branch from c3a1420 to ecb559e Compare October 9, 2020 10:58

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020

navidshaikh approved these changes Oct 9, 2020

View reviewed changes

knative-prow-robot assigned navidshaikh Oct 9, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020

knative-prow-robot merged commit 4ebd7ed into knative:master Oct 9, 2020

navidshaikh mentioned this pull request Oct 12, 2020

[release-0.17] Backport #1052 and #1054 #1058

Merged

navidshaikh mentioned this pull request Oct 12, 2020

[release-0.18] Backport #1052 and #1054 #1059

Merged

navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Oct 12, 2020

navidshaikh added backported-to/0.17 and removed backport/candidate Consider this PR to be backported to the release branch labels Oct 12, 2020

dsimansk pushed a commit to dsimansk/client that referenced this pull request May 25, 2022

🤖 CI was here...🔥 (knative#1054)

3d66f9a

Conversation

zroubalik commented Oct 8, 2020

Description

Reference

Uh oh!

knative-prow-robot left a comment

Choose a reason for hiding this comment

Description

Reference

Uh oh!

Uh oh!

knative-prow-robot commented Oct 8, 2020

Uh oh!

knative-prow-robot commented Oct 8, 2020

Uh oh!

navidshaikh left a comment

Choose a reason for hiding this comment

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

maximilien left a comment

Choose a reason for hiding this comment

Uh oh!

zroubalik commented Oct 9, 2020

Uh oh!

navidshaikh left a comment

Choose a reason for hiding this comment

Uh oh!

zroubalik commented Oct 9, 2020

Uh oh!

knative-metrics-robot commented Oct 9, 2020

Uh oh!

zroubalik commented Oct 9, 2020

Uh oh!

navidshaikh left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Oct 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants