Skip to content

[release-0.18] Backport #1052 and #1054#1059

Merged
knative-prow-robot merged 3 commits intoknative:release-0.18from
navidshaikh:pr/kn-0.18-v1
Oct 12, 2020
Merged

[release-0.18] Backport #1052 and #1054#1059
knative-prow-robot merged 3 commits intoknative:release-0.18from
navidshaikh:pr/kn-0.18-v1

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Oct 12, 2020

rhuss and others added 3 commits October 12, 2020 13:19
@rhuss @navidshaikh
Fix for test flake when sync waiting and an intermediate error occurs (…
4ab02c3 
…knative#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added
@zroubalik @navidshaikh
Add WithLabel list filter to serving client lib (knative#1054)
28d195b 
* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* adding tests

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* update changelog

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@navidshaikh
Update CHANGELOG
bb59aaf
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2020
@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Oct 12, 2020
@navidshaikh navidshaikh changed the base branch from master to release-0.18 October 12, 2020 07:53
@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Oct 12, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2020
@zroubalik
Copy link
Copy Markdown
Contributor

zroubalik commented Oct 12, 2020

@googlebot I consent.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Oct 12, 2020

/retest

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Oct 12, 2020

@googlebot I consent.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Oct 12, 2020

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 12, 2020
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Oct 12, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@knative-prow-robot knative-prow-robot merged commit b6fdb5c into knative:release-0.18 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/pr A backport PR which is target to a release branch. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@navidshaikh @knative-prow-robot @zroubalik @rhuss