Remove prometheus addon from Istio installation instructions by arturenault · Pull Request #3096 · knative/docs

arturenault · 2020-12-08T19:31:13Z

Fixes knative/serving#10221

Proposed Changes

This addon is no longer supported in Istio 1.8. Remove it since it was disabled anyways.

This addon is no longer supported in 1.8. Fixes knative/serving#10221

nak3

@arturenault Could you also remove cluster-local-gateway?

nak3

/lgtm

arturenault · 2020-12-14T17:19:38Z

@nak3 can I get an approval here? You're still assigned

I'm not totally clear on the difference between lgtm and approval yet, so let me know if I should ping someone else

nak3 · 2020-12-15T00:14:52Z

/approve

But I think I don't have the permission to approve. @abrennan89 @tcnghia could you please take a look?

/cc @abrennan89 @tcnghia

tcnghia

/lgtm

knative-prow-robot · 2020-12-15T01:50:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arturenault, nak3, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tcnghia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway

* remove prometheus component Istioctl version: ``` client version: 1.8.2 control plane version: 1.8.2 data plane version: 1.8.2 (2 proxies) ``` I get this error: ``` Error: failed to install manifests: errors occurred during operation: failed to create Istio control plane with spec: hub:"docker.io/istio" tag:1.8.2 mesh_config:<key:"defaultConfig" value:map[proxyMetadata:map[]] > mesh_config:<key:"enablePrometheusMerge" value:true > components:<base:<enabled:<BoolValue:<value:true > > > pilot:<enabled:<BoolValue:<value:true > > tag:<nil> spec:<nil> k8s:<env:<name:"POD_NAME" valueFrom:<fieldRef:<apiVersion:"v1" fieldPath:"metadata.name" > > > env:<name:"POD_NAMESPACE" valueFrom:<fieldRef:<apiVersion:"v1" fieldPath:"metadata.namespace" > > > readiness_probe:<httpGet:<path:"/ready" port:<IntOrString:<type:0 intVal:8080 strVal:"" > > > initialDelaySeconds:1 timeoutSeconds:5 periodSeconds:3 > strategy:<rollingUpdate:<maxUnavailable:<IntOrString:<type:1 intVal:0 strVal:"25%" > > maxSurge:<IntOrString:<type:1 intVal:0 strVal:"100%" > > > > > > cni:<enabled:<BoolValue:<> > tag:<nil> spec:<nil> > istiod_remote:<enabled:<BoolValue:<> > tag:<nil> spec:<nil> > ingress_gateways:<enabled:<BoolValue:<value:true > > name:"istio-ingressgateway" tag:<nil> k8s:<env:<name:"ISTIO_META_ROUTER_MODE" value:"standard" > hpa_spec:<scaleTargetRef:<kind:"Deployment" name:"istio-ingressgateway" apiVersion:"apps/v1" > minReplicas:1 maxReplicas:5 metrics:<type:"Resource" resource:<name:"cpu" targetAverageUtilization:80 > > > resources:<limits:<key:"cpu" value:"2000m" > limits:<key:"memory" value:"1024Mi" > requests:<key:"cpu" value:"100m" > requests:<key:"memory" value:"128Mi" > > service:<ports:<name:"status-port" protocol:"TCP" port:15021 targetPort:<IntOrString:<type:0 intVal:15021 strVal:"" > > > ports:<name:"http2" protocol:"TCP" port:80 targetPort:<IntOrString:<type:0 intVal:8080 strVal:"" > > > ports:<name:"https" protocol:"TCP" port:443 targetPort:<IntOrString:<type:0 intVal:8443 strVal:"" > > > ports:<name:"tcp-istiod" protocol:"TCP" port:15012 targetPort:<IntOrString:<type:0 intVal:15012 strVal:"" > > > ports:<name:"tls" protocol:"TCP" port:15443 targetPort:<IntOrString:<type:0 intVal:15443 strVal:"" > > > > strategy:<rollingUpdate:<maxUnavailable:<IntOrString:<type:1 intVal:0 strVal:"25%" > > maxSurge:<IntOrString:<type:1 intVal:0 strVal:"100%" > > > > > > ingress_gateways:<enabled:<BoolValue:<value:true > > name:"cluster-local-gateway" label:<key:"app" value:"cluster-local-gateway" > label:<key:"istio" value:"cluster-local-gateway" > tag:<nil> k8s:<service:<ports:<name:"status-port" port:15020 > ports:<name:"http2" port:80 targetPort:<IntOrString:<type:0 intVal:8080 strVal:"" > > > ports:<name:"https" port:443 targetPort:<IntOrString:<type:0 intVal:8443 strVal:"" > > > type:"ClusterIP" > > > egress_gateways:<enabled:<BoolValue:<> > name:"istio-egressgateway" tag:<nil> k8s:<env:<name:"ISTIO_META_ROUTER_MODE" value:"standard" > hpa_spec:<scaleTargetRef:<kind:"Deployment" name:"istio-egressgateway" apiVersion:"apps/v1" > minReplicas:1 maxReplicas:5 metrics:<type:"Resource" resource:<name:"cpu" targetAverageUtilization:80 > > > resources:<limits:<key:"cpu" value:"2000m" > limits:<key:"memory" value:"1024Mi" > requests:<key:"cpu" value:"100m" > requests:<key:"memory" value:"128Mi" > > service:<ports:<name:"http2" protocol:"TCP" port:80 targetPort:<IntOrString:<type:0 intVal:8080 strVal:"" > > > ports:<name:"https" protocol:"TCP" port:443 targetPort:<IntOrString:<type:0 intVal:8443 strVal:"" > > > ports:<name:"tls" protocol:"TCP" port:15443 targetPort:<IntOrString:<type:0 intVal:15443 strVal:"" > > > > strategy:<rollingUpdate:<maxUnavailable:<IntOrString:<type:1 intVal:0 strVal:"25%" > > maxSurge:<IntOrString:<type:1 intVal:0 strVal:"100%" > > > > > > > addon_components:<key:"istiocoredns" value:<enabled:<BoolValue:<> > spec:<nil> > > addon_components:<key:"pilot" value:<enabled:<BoolValue:<value:true > > spec:<nil> > > addon_components:<key:"prometheus" value:<enabled:<BoolValue:<> > spec:<nil> > > values:<key:"base" value:map[enableCRDTemplates:false validationURL:] > values:<key:"clusterResources" value:true > values:<key:"gateways" value:map[istio-egressgateway:map[autoscaleEnabled:true env:map[] name:istio-egressgateway secretVolumes:[map[mountPath:/etc/istio/egressgateway-certs name:egressgateway-certs secretName:istio-egressgateway-certs] map[mountPath:/etc/istio/egressgateway-ca-certs name:egressgateway-ca-certs secretName:istio-egressgateway-ca-certs]] type:ClusterIP zvpn:map[]] istio-ingressgateway:map[autoscaleEnabled:true env:map[] name:istio-ingressgateway secretVolumes:[map[mountPath:/etc/istio/ingressgateway-certs name:ingressgateway-certs secretName:istio-ingressgateway-certs] map[mountPath:/etc/istio/ingressgateway-ca-certs name:ingressgateway-ca-certs secretName:istio-ingressgateway-ca-certs]] type:LoadBalancer zvpn:map[]]] > values:<key:"global" value:map[arch:map[amd64:2 ppc64le:2 s390x:2] configValidation:true defaultNodeSelector:map[] defaultPodDisruptionBudget:map[enabled:true] defaultResources:map[requests:map[cpu:10m]] imagePullPolicy: imagePullSecrets:[] istioNamespace:istio-system istiod:map[enableAnalysis:false] jwtPolicy:first-party-jwt logAsJson:false logging:map[level:default:info] meshExpansion:map[enabled:false useILB:false] meshNetworks:map[] mountMtlsCerts:false multiCluster:map[clusterName: enabled:false] network: omitSidecarInjectorConfigMap:false oneNamespace:false operatorManageWebhooks:false pilotCertProvider:istiod priorityClassName: proxy:map[autoInject:disabled clusterDomain:cluster.local componentLogLevel:misc:error enableCoreDump:false excludeIPRanges: excludeInboundPorts: excludeOutboundPorts: image:proxyv2 includeIPRanges:* logLevel:warning privileged:false readinessFailureThreshold:30 readinessInitialDelaySeconds:1 readinessPeriodSeconds:2 resources:map[limits:map[cpu:2000m memory:1024Mi] requests:map[cpu:100m memory:128Mi]] statusPort:15020 tracer:zipkin] proxy_init:map[image:proxyv2 resources:map[limits:map[cpu:2000m memory:1024Mi] requests:map[cpu:10m memory:10Mi]]] sds:map[token:map[aud:istio-ca]] sts:map[servicePort:0] tracer:map[datadog:map[] lightstep:map[] stackdriver:map[] zipkin:map[]] useMCP:false] > values:<key:"istiocoredns" value:map[coreDNSImage:coredns/coredns coreDNSPluginImage:istio/coredns-plugin:0.2-istio-1.1 coreDNSTag:1.6.2] > values:<key:"istiodRemote" value:map[injectionURL:] > values:<key:"pilot" value:map[autoscaleEnabled:true autoscaleMax:5 autoscaleMin:1 configMap:true cpu:map[targetAverageUtilization:80] deploymentLabels:<nil> enableProtocolSniffingForInbound:true enableProtocolSniffingForOutbound:true env:map[ENABLE_LEGACY_FSGROUP_INJECTION:false] image:pilot keepaliveMaxServerConnectionAge:30m nodeSelector:map[] replicaCount:1 traceSampling:1] > values:<key:"sidecarInjectorWebhook" value:map[enableNamespacesByDefault:false objectSelector:map[autoInject:true enabled:false] rewriteAppHTTPProbe:true] > values:<key:"telemetry" value:map[enabled:true v2:map[enabled:true metadataExchange:map[wasmEnabled:false] prometheus:map[enabled:true wasmEnabled:false] stackdriver:map[configOverride:map[] enabled:false logging:false monitoring:false topology:false]]] > error: component "prometheus" is not longer supported. Please remove it from the addonComponent configuration. See https://istio.io/latest/blog/2020/addon-rework/ for more info ``` Prometheus was not enabled in the configuration file, so removing those lines should be a problem * make the same change with #3096 for installating istio

…lease-0.19 (#3152) * Remove prometheus addon from Istio installation instructions (#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway * Add docs on mTLS and Istio authorization policy (#3118) * Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md * Fix typo in istio authorization docs (#3120) Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.

…lease-0.19 (knative#3152) * Remove prometheus addon from Istio installation instructions (knative#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway * Add docs on mTLS and Istio authorization policy (knative#3118) * Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md * Fix typo in istio authorization docs (knative#3120) Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.

Remove prometheus addon from Istio installation instructions

03303b7

This addon is no longer supported in 1.8. Fixes knative/serving#10221

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 8, 2020

knative-prow-robot requested review from grantr and houshengbo December 8, 2020 19:31

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2020

nak3 reviewed Dec 9, 2020

View reviewed changes

Remove cluster-local-gateway

086c491

knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2020

nak3 approved these changes Dec 9, 2020

View reviewed changes

knative-prow-robot assigned nak3 Dec 9, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020

knative-prow-robot requested review from abrennan89 and tcnghia December 15, 2020 00:14

tcnghia approved these changes Dec 15, 2020

View reviewed changes

knative-prow-robot assigned tcnghia Dec 15, 2020

knative-prow-robot added the approved label Dec 15, 2020

knative-prow-robot merged commit 1bb8f79 into knative:release-0.19 Dec 15, 2020

nak3 mentioned this pull request Dec 15, 2020

Installing Istio for Knative(docs/install/installing-istio.md) #3104

Closed

arturenault mentioned this pull request Jan 15, 2021

Cherry pick a few commits that were erroneously made directly into release-0.19 #3152

Merged

nak3 mentioned this pull request Jan 18, 2021

remove prometheus component #3158

Merged

yasharne added a commit to yasharne/docs that referenced this pull request Jan 20, 2021

make the same change with knative#3096 for installating istio

b08ca98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove prometheus addon from Istio installation instructions#3096

Remove prometheus addon from Istio installation instructions#3096
knative-prow-robot merged 2 commits into
knative:release-0.19from
arturenault:patch-3

arturenault commented Dec 8, 2020

Uh oh!

nak3 left a comment

Uh oh!

nak3 left a comment

Uh oh!

arturenault commented Dec 14, 2020

Uh oh!

nak3 commented Dec 15, 2020

Uh oh!

tcnghia left a comment

Uh oh!

knative-prow-robot commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

arturenault commented Dec 8, 2020

Proposed Changes

Uh oh!

nak3 left a comment

Choose a reason for hiding this comment

Uh oh!

nak3 left a comment

Choose a reason for hiding this comment

Uh oh!

arturenault commented Dec 14, 2020

Uh oh!

nak3 commented Dec 15, 2020

Uh oh!

tcnghia left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants