Cherry pick a few commits that were erroneously made directly into release-0.19#3152
Merged
Merged
Conversation
Contributor
arturenault
commented
Jan 15, 2021
arturenault
commented
- Remove prometheus addon from Istio installation instructions (Remove prometheus addon from Istio installation instructions #3096)
- Add docs on mTLS and Istio authorization policy (Add docs on mTLS and Istio authorization policy #3118)
- Fix typo in istio authorization docs (Fix typo in istio authorization docs #3120)
added 3 commits
January 15, 2021 00:20
…#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway
* Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md
Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
knative-prow-robot
added
the
size/M
Contributor
|
/lgtm |
Contributor
Author
|
/assign @markusthoemmes |
Contributor
Author
|
@tcnghia @markusthoemmes ping :) |
abrennan89
approved these changes
Jan 27, 2021
Contributor
abrennan89
left a comment
abrennan89
left a comment
There was a problem hiding this comment.
/lgtm
/hold
@markusthoemmes please remove the hold when you're able to take a look and approve this
knative-prow-robot
added
the
do-not-merge/hold
markusthoemmes
approved these changes
Jan 28, 2021
Contributor
markusthoemmes
left a comment
markusthoemmes
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/unhold
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, arturenault, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 6, 2021
…lease-0.19 (knative#3152) * Remove prometheus addon from Istio installation instructions (knative#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway * Add docs on mTLS and Istio authorization policy (knative#3118) * Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md * Fix typo in istio authorization docs (knative#3120) Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.