Fix typo in istio authorization docs#3120
Merged
Merged
Conversation
Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
knative-prow-robot
added
the
size/XS
Contributor
Author
|
Also, just saw the instructions in the PR markdown for merging into master and then cherry-picking into release. This and #3118 only went into release-0.19 because that was the default. Once this is merged I'll cherry-pick both into master. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arturenault, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
arturenault
pushed a commit
to arturenault/docs
that referenced
this pull request
Jan 15, 2021
Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
arturenault
pushed a commit
to arturenault/docs
that referenced
this pull request
Jan 21, 2021
Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 21, 2021
* Add docs on mTLS and Istio authorization policy (#3118) * Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md * Fix typo in istio authorization docs (#3120) Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 28, 2021
…lease-0.19 (#3152) * Remove prometheus addon from Istio installation instructions (#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway * Add docs on mTLS and Istio authorization policy (#3118) * Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md * Fix typo in istio authorization docs (#3120) Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 6, 2021
…lease-0.19 (knative#3152) * Remove prometheus addon from Istio installation instructions (knative#3096) * Remove prometheus addon from Istio installation instructions This addon is no longer supported in 1.8. Fixes knative/serving#10221 * Remove cluster-local-gateway * Add docs on mTLS and Istio authorization policy (knative#3118) * Add documentation about mTLS and authorization policies * Add image link * Update istio-authorization.md * Fix typo in istio authorization docs (knative#3120) Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to add the knative-serving namespace, which is mentioned in the previous paragraph.