Remove Istio dependency from Eventing (Part - 2) by akashrv · Pull Request #1058 · knative/eventing

akashrv · 2019-04-16T00:41:24Z

Part of series of PRs for #294
Previous PRs for reference:

Remove Istio dependency from Eventing (Part - 1) #1044

Proposed Changes

Removed Istio dependency from Kafka channel
- Kafka Channel dispatcher will watch all channels and maintain a map of host headers to channels
Message_Receiver enables its consumer to provide custom functions to map hostName to channel reference.
Istio sidecars still exist. These will be removed after all channels stop using istio. Removing side-car now could break complex scenarios such as kafka dispatcher dispatching to a natss channel.

Release Note

Knative Eventing will create a unique K8s service of type ExternalName for each channel when using Kafka ClusterChannelProvisioner

tests against channels other than in-memory

…xternalName

More UTs needded

…iokafka

Harwayne

/lgtm
/approve

knative-prow-robot · 2019-04-19T19:35:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashrv, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Harwayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Harwayne

/lgtm

knative-metrics-robot · 2019-04-19T19:48:06Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
contrib/gcppubsub/pkg/dispatcher/receiver/receiver.go	93.6%	92.0%	-1.6
contrib/kafka/pkg/controller/channel/provider.go	12.5%	16.7%	4.2
contrib/kafka/pkg/controller/channel/reconcile.go	77.0%	81.7%	4.7
contrib/kafka/pkg/dispatcher/dispatcher.go	71.8%	68.5%	-3.4
contrib/natss/pkg/dispatcher/dispatcher/dispatcher.go	57.1%	56.6%	-0.6
pkg/channelwatcher/channel_watcher.go	Do not exist	50.0%
pkg/provisioners/channel_util.go	92.4%	90.8%	-1.6
pkg/provisioners/message_receiver.go	79.4%	74.3%	-5.1
pkg/sidecar/fanout/fanout_handler.go	100.0%	96.2%	-3.8
pkg/sidecar/multichannelfanout/config.go	Do not exist	100.0%
pkg/sidecar/multichannelfanout/multi_channel_fanout_handler.go	100.0%	91.3%	-8.7

akashrv · 2019-04-19T20:42:27Z

/retest

Co-authored-by: serverless-qe <serverless-support@redhat.com>

akashrv and others added 28 commits April 5, 2019 10:13

WIP

99fddec

Merge branch 'noistio2' of github.com:akashrv/eventing into noistio2

c08546a

WIP - In-memory working with E2E tests

c642cea

WIP - remove istio dependency from in-memroy channel

2a4faae

UTs pass, E2E tests pass with in-memory as well as kafka

bd7ae68

fixed uts that failed due to last K8s service change

df4487f

Merge branch 'master' of github.com:knative/eventing into noistiokafka

824efe6

Removed unnecessary space from a line

23ae8b4

Merge branch 'noistio2' of github.com:akashrv/eventing into noistio2

a04d6d9

dding istio annotation to test POD. This will ve needed when running E2E

bb7ab3e

tests against channels other than in-memory

Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka

83e519d

Bug fix to set clusterIp of K8s service only when it is not of type E…

c646dcd

…xternalName

WIP kafka channel

485f6b3

Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka

6fd3378

WIP kafka - UTs and E2E pass

37bae81

More UTs needded

Updated code based on PR comments

feb5e64

Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka

3414ba3

WIP

c1b8581

Updates based on PR comments

d2c831f

Merge branch 'master' of github.com:knative/eventing into noistio2

d61cd1a

Updates based on PR comments

16a6ffc

Fixed UTs

67611dc

Updated VENDOR_LICENSE

2cc8525

Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka

5b68a3f

WIP. Update fanout sidecar

3b3f16f

Merge branch 'master' of github.com:knative/eventing into noistiokafka

f1904fe

Merge from upstream master

f065d22

UTs pass, ITs passed. COde ready for PR

a645dce

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 16, 2019

knative-prow-robot requested a review from n3wscott April 16, 2019 00:41

matzew reviewed Apr 17, 2019

View reviewed changes

Comment thread contrib/kafka/pkg/dispatcher/dispatcher.go Outdated

Harwayne reviewed Apr 17, 2019

View reviewed changes

vaikas reviewed Apr 18, 2019

View reviewed changes

Comment thread contrib/kafka/config/kafka.yaml

Comment thread contrib/kafka/config/kafka.yaml

akashrv and others added 3 commits April 17, 2019 18:03

Changes based on PR comments

d1a1bd5

Merge branch 'master' of github.com:knative/eventing into noistiokafka

2d52ee9

Added back permission that was removed by mistake

d71fecf

akashrv commented Apr 18, 2019

View reviewed changes

Comment thread contrib/kafka/config/kafka.yaml

akashrv added 3 commits April 18, 2019 16:45

Remove istio references

6f5d4f8

Removed one more reference of istio

9f53403

Merge branch 'noistiokafka' of github.com:akashrv/eventing into noist…

10a0045

…iokafka

Harwayne reviewed Apr 19, 2019

View reviewed changes

Comment thread contrib/kafka/pkg/dispatcher/dispatcher.go

Comment thread contrib/kafka/pkg/dispatcher/dispatcher.go Outdated

akashrv added 2 commits April 19, 2019 12:07

Merge branch 'master' of github.com:knative/eventing into noistiokafka

f17056b

Updates based on PR comments. Ready to merge into master

a2e3d81

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2019

Harwayne reviewed Apr 19, 2019

View reviewed changes

Fixed a typo

d71b410

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 19, 2019

Harwayne reviewed Apr 19, 2019

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2019

knative-prow-robot merged commit bd4135e into knative:master Apr 19, 2019

akashrv mentioned this pull request Apr 19, 2019

Remove Istio dependency from Eventing (Part - 3) - Natss #1074

Merged

Harwayne mentioned this pull request Apr 25, 2019

Precreate the Kafka ConfigMap, because the dispatcher will flap until it exists #831

Closed

This was referenced Apr 25, 2019

Remove Istio dependency from Eventing (Part - 4) - gcp-pubsub #1107

Merged

Remove Istio dependency from Eventing (Part - 5) - final cleanup #1119

Merged

lberk pushed a commit to lberk/eventing that referenced this pull request Jan 14, 2021

add skonto (knative#1058)

d374acb

creydr pushed a commit to creydr/knative-eventing that referenced this pull request Feb 5, 2025

Update dependabot configurations (knative#1058)

1d0b371

Co-authored-by: serverless-qe <serverless-support@redhat.com>

Conversation

akashrv commented Apr 16, 2019

Proposed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Apr 19, 2019

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

knative-metrics-robot commented Apr 19, 2019

Uh oh!

akashrv commented Apr 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants