Skip to content

Remove Istio dependency from Eventing (Part - 3) - Natss#1074

Merged
knative-prow-robot merged 50 commits into
knative:masterfrom
akashrv:noistionatss
Apr 25, 2019
Merged

Remove Istio dependency from Eventing (Part - 3) - Natss#1074
knative-prow-robot merged 50 commits into
knative:masterfrom
akashrv:noistionatss

Conversation

@akashrv
Copy link
Copy Markdown
Contributor

@akashrv akashrv commented Apr 19, 2019

Part of series of PRs for #294
Previous PRs for reference:
#1044
#1058

Proposed Changes

  • Stop creating istio virtual service for NATSS channel
  • Dispatcher is still deployed with a side-car. Once all channels stop using Istio Virtual service, I'll send a PR to remove all istio sidecars and injection related code.

Release Note

Knative Eventing will create a unique K8s service of type ExternalName for each channel when using Natss ClusterChannelProvisioner

akashrv and others added 30 commits April 5, 2019 10:13
@akashrv
WIP
99fddec
@akashrv
Merge branch 'noistio2' of github.com:akashrv/eventing into noistio2
c08546a
@akashrv
WIP - In-memory working with E2E tests
c642cea
@akashrv
WIP - remove istio dependency from in-memroy channel
2a4faae
@akashrv
UTs pass, E2E tests pass with in-memory as well as kafka
bd7ae68
@akashrv
fixed uts that failed due to last K8s service change
df4487f
@akashrv
Merge branch 'master' of github.com:knative/eventing into noistiokafka
824efe6
@akashrv
Removed unnecessary space from a line
23ae8b4
@akashrv
Merge branch 'noistio2' of github.com:akashrv/eventing into noistio2
a04d6d9
@akashrv
dding istio annotation to test POD. This will ve needed when running E2E
bb7ab3e 
tests against channels other than in-memory
@akashrv
Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka
83e519d
@akashrv
Bug fix to set clusterIp of K8s service only when it is not of type E…
c646dcd 
…xternalName
@akashrv
WIP kafka channel
485f6b3
@akashrv
Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka
6fd3378
@akashrv
WIP kafka - UTs and E2E pass
37bae81 
More UTs needded
@akashrv
Updated code based on PR comments
feb5e64
@akashrv
Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka
3414ba3
@akashrv
WIP
c1b8581
@akashrv
Updates based on PR comments
d2c831f
@akashrv
Merge branch 'master' of github.com:knative/eventing into noistio2
d61cd1a
@akashrv
Updates based on PR comments
16a6ffc
@akashrv
Fixed UTs
67611dc
@akashrv
Updated VENDOR_LICENSE
2cc8525
@akashrv
Merge branch 'noistio2' of github.com:akashrv/eventing into noistiokafka
5b68a3f
@akashrv
WIP. Update fanout sidecar
3b3f16f
@akashrv
Merge branch 'master' of github.com:knative/eventing into noistiokafka
f1904fe
@akashrv
Merge from upstream master
f065d22
@akashrv
UTs pass, ITs passed. COde ready for PR
a645dce
@akashrv
Update natss to not use ISTIO. UTs and E2E tests pass.
fdc4b57
@akashrv
Updates based on PR comments
09e4dfa
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2019
@akashrv
Copy link
Copy Markdown
Contributor Author

akashrv commented Apr 19, 2019

/assign @vaikas-google @Harwayne

Harwayne
Harwayne reviewed Apr 19, 2019
View reviewed changes
Comment thread contrib/natss/pkg/dispatcher/dispatcher/dispatcher.go
Comment thread contrib/natss/pkg/dispatcher/dispatcher/dispatcher.go Outdated
Comment thread pkg/channelwatcher/channel_watcher.go Outdated
Comment thread contrib/natss/config/broker/natss.yaml
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Apr 22, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/natss/pkg/controller/channel/reconcile.go 75.9% 78.0% 2.1
contrib/natss/pkg/dispatcher/dispatcher/dispatcher.go 57.1% 58.2% 1.1
pkg/channelwatcher/channel_watcher.go Do not exist 50.0%

@akashrv
Copy link
Copy Markdown
Contributor Author

akashrv commented Apr 25, 2019

/retest

@Harwayne
Copy link
Copy Markdown
Contributor

Harwayne commented Apr 25, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashrv, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@knative-prow-robot knative-prow-robot merged commit 9565689 into knative:master Apr 25, 2019
This was referenced Apr 25, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@Harwayne Harwayne Harwayne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akashrv @knative-metrics-robot @Harwayne @knative-prow-robot @googlebot @vaikas