Remove Istio dependency from Eventing (Part - 4) - gcp-pubsub#1107
Merged
Conversation
tests against channels other than in-memory
More UTs needded
knative-prow-robot
added
the
size/XL
Contributor
Author
|
/assign @Harwayne @vaikas-google |
akashrv
commented
Apr 25, 2019
| } | ||
|
|
||
| // NewHostNameToChannelRefMap parses each channel from cList and creates a map[string(Status.Address.HostName)]ChannelReference | ||
| func NewHostNameToChannelRefMap(cList []eventingv1alpha1.Channel) (map[string]ChannelReference, error) { |
Contributor
Author
There was a problem hiding this comment.
UT is missing. Will add it in next iteration in the same PR
Harwayne
reviewed
Apr 25, 2019
|
The following is the coverage report on pkg/.
|
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akashrv, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
Now that this is merged, have we eliminated our istio dependency? |
Contributor
Author
|
Istio dependency is eliminated. I have a last and final PR to remove it
from dispatchers and tests. The package dependency will still stay as
knative/pkg needs it.
…On Mon, Apr 29, 2019 at 10:08 AM Grant Rodgers ***@***.***> wrote:
Now that this is merged, have we eliminated our istio dependency?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1107 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKYQBFBPNYZMFLFSX757PSDPS4TQNANCNFSM4HIRGYXA>
.
--
Regards,
Akash
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of series of PRs for #294
Previous PRs for reference:
#1044
#1058
#1074
Proposed Changes
Release Note