Skip to content

add namesapce and service account#109

Merged
google-prow-robot merged 1 commit into
knative:masterfrom
vaikas:bindingtobus
Jun 25, 2018
Merged

add namesapce and service account#109
google-prow-robot merged 1 commit into
knative:masterfrom
vaikas:bindingtobus

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jun 23, 2018

Fixes Issue #

Proposed Changes

  • Run the binding code in the namespare where the binding is created in.
  • Add ServiceAccount to Bind resource. This way when a binding code gets run, it and any receive adapter can use that as well.
  • Inject Istio to k8s receive adapter so that it can target a channel (follow on PR for that functionality.

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jun 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas vaikas requested a review from grantr June 23, 2018 19:18
@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2018
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jun 23, 2018

/assign @grantr

@vaikas vaikas mentioned this pull request Jun 25, 2018
Merged
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jun 25, 2018

/assign @scothis

@scothis
Copy link
Copy Markdown
Contributor

scothis commented Jun 25, 2018

My comments from #111 really belonged here.

To summarize, I'm not crazy about the samples explicitly using cluster-admin as users will copy/paste samples into production without thinking about every line of code. I don't want to block this PR on it though as long as we followup (#113).

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2018
@google-prow-robot google-prow-robot merged commit 5f708a0 into knative:master Jun 25, 2018
@vaikas vaikas deleted the bindingtobus branch June 25, 2018 18:16
@vaikas vaikas mentioned this pull request Jul 11, 2018
Closed
matzew pushed a commit to matzew/eventing that referenced this pull request May 20, 2019
@openshift-merge-robot
Merge pull request knative#109 from matzew/master_maistra_10_patch
7450bd4 
Adding latest maistra patch to master
matzew added a commit to matzew/eventing that referenced this pull request Feb 10, 2023
@matzew @knative-prow-robot @pierDipi
[release-1.9] Install source at requirement phase in conformance tests (
e480980 
knative#6713) (knative#109)

This is an automated cherry-pick of knative#6712

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

Assignees

@grantr grantr

@scothis scothis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vaikas @google-prow-robot @scothis @grantr