Skip to content

[0.17] Ported recent test infra improvements#4403

Merged
knative-prow-robot merged 4 commits into
knative:release-0.17from
slinkydeveloper:release-0.17
Oct 27, 2020
Merged

[0.17] Ported recent test infra improvements#4403
knative-prow-robot merged 4 commits into
knative:release-0.17from
slinkydeveloper:release-0.17

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Oct 27, 2020

slinkydeveloper and others added 3 commits October 27, 2020 16:19
@slinkydeveloper
Nit (knative#4385)
d5d747f 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3ceaad4)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@vaikas @slinkydeveloper
emit a k8s event when dropping events (knative#4389)
29f347e 
* emit a k8s event when dropping events

Signed-off-by: Ville Aikas <vaikas@vmware.com>

* go imports

Signed-off-by: Ville Aikas <vaikas@vmware.com>

* tags

Signed-off-by: Ville Aikas <vaikas@vmware.com>

* fix silliness

Signed-off-by: Ville Aikas <vaikas@vmware.com>

* simplify

Signed-off-by: Ville Aikas <vaikas@vmware.com>
(cherry picked from commit 0a54fd9)
@slinkydeveloper
[recordevents] Removed EventBroadcaster usage and replaced with manua…
0c25366 
…l send (knative#4393)

* Removed EventBroadcaster usage and replaced with manual creation and send of events

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Boilerplate

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove redundant format
Removed sequence annotation

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added required value

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* ?!?!

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Maybe this one fix the issue?

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Maybe this one fix the issue?

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Removed useless double log line

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove useless headers

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Missing host header

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Nit

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Now it works on my machine, i'm warning you prow!

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Nit

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Now it works for long events too

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Suggestions

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fixed the dropped counter thing

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Nit

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 7de59ec)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2020
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 27, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Oct 27, 2020
@google-cla google-cla Bot added the cla: no Indicates the PR's author has not signed the CLA. label Oct 27, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@slinkydeveloper
Wrong merge fix
c58b0f7 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 27, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 27, 2020

I consent
@googlebot I fixed it.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 27, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Oct 27, 2020

@googlebot I fixed it.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 27, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Oct 27, 2020

Both authors have previously accepted the CLA

@grantr grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 27, 2020
matzew
matzew approved these changes Oct 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for the backport @slinkydeveloper

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ba45a11 into knative:release-0.17 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slinkydeveloper @vaikas @grantr @knative-prow-robot @matzew