Some nits in our test-infra I've found during a burning debugging session by slinkydeveloper · Pull Request #4385 · knative/eventing

slinkydeveloper · 2020-10-26T09:19:33Z

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Proposed Changes

k8s events printed at the end of the test now are reordered before being printed
Set the observer name in recordevents
Include the host header in recordevents
Proper logging of event info

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

codecov · 2020-10-26T09:25:57Z

Codecov Report

Merging #4385 into master will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4385      +/-   ##
==========================================
+ Coverage   80.80%   81.13%   +0.33%     
==========================================
  Files         288      287       -1     
  Lines        8033     8032       -1     
==========================================
+ Hits         6491     6517      +26     
+ Misses       1151     1128      -23     
+ Partials      391      387       -4

Impacted Files	Coverage Δ
pkg/channel/swappable/swappable_message_handler.go
...econciler/inmemorychannel/dispatcher/controller.go	`77.77% <0.00%> (+2.77%)`	⬆️
...nnelfanout/multi_channel_fanout_message_handler.go	`91.17% <0.00%> (+9.03%)`	⬆️
pkg/channel/fanout/fanout_message_handler.go	`91.53% <0.00%> (+12.05%)`	⬆️
...iler/inmemorychannel/dispatcher/inmemorychannel.go	`92.68% <0.00%> (+26.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7734430...c5808d3. Read the comment docs.

vaikas · 2020-10-26T09:26:02Z

/lgtm
/approve

knative-prow-robot · 2020-10-26T09:26:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3ceaad4) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Nit (#4385) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3ceaad4) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * emit a k8s event when dropping events (#4389) * emit a k8s event when dropping events Signed-off-by: Ville Aikas <vaikas@vmware.com> * go imports Signed-off-by: Ville Aikas <vaikas@vmware.com> * tags Signed-off-by: Ville Aikas <vaikas@vmware.com> * fix silliness Signed-off-by: Ville Aikas <vaikas@vmware.com> * simplify Signed-off-by: Ville Aikas <vaikas@vmware.com> (cherry picked from commit 0a54fd9) * [recordevents] Removed EventBroadcaster usage and replaced with manual send (#4393) * Removed EventBroadcaster usage and replaced with manual creation and send of events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Boilerplate Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove redundant format Removed sequence annotation Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Added required value Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * ?!?! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Removed useless double log line Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove useless headers Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing host header Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works on my machine, i'm warning you prow! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works for long events too Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Suggestions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed the dropped counter thing Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 7de59ec) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Wrong merge fix Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>

* Nit (#4385) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3ceaad4) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * emit a k8s event when dropping events (#4389) * emit a k8s event when dropping events Signed-off-by: Ville Aikas <vaikas@vmware.com> * go imports Signed-off-by: Ville Aikas <vaikas@vmware.com> * tags Signed-off-by: Ville Aikas <vaikas@vmware.com> * fix silliness Signed-off-by: Ville Aikas <vaikas@vmware.com> * simplify Signed-off-by: Ville Aikas <vaikas@vmware.com> (cherry picked from commit 0a54fd9) * [recordevents] Removed EventBroadcaster usage and replaced with manual send (#4393) * Removed EventBroadcaster usage and replaced with manual creation and send of events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Boilerplate Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove redundant format Removed sequence annotation Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Added required value Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * ?!?! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Removed useless double log line Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove useless headers Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing host header Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works on my machine, i'm warning you prow! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works for long events too Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Suggestions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed the dropped counter thing Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 7de59ec) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>

* Nit (knative#4385) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3ceaad4) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * emit a k8s event when dropping events (knative#4389) * emit a k8s event when dropping events Signed-off-by: Ville Aikas <vaikas@vmware.com> * go imports Signed-off-by: Ville Aikas <vaikas@vmware.com> * tags Signed-off-by: Ville Aikas <vaikas@vmware.com> * fix silliness Signed-off-by: Ville Aikas <vaikas@vmware.com> * simplify Signed-off-by: Ville Aikas <vaikas@vmware.com> (cherry picked from commit 0a54fd9) * [recordevents] Removed EventBroadcaster usage and replaced with manual send (knative#4393) * Removed EventBroadcaster usage and replaced with manual creation and send of events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Boilerplate Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove redundant format Removed sequence annotation Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Added required value Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * ?!?! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Removed useless double log line Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove useless headers Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing host header Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works on my machine, i'm warning you prow! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works for long events too Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Suggestions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed the dropped counter thing Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 7de59ec) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Wrong merge fix Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>

Nit

c5808d3

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 26, 2020

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2020

knative-prow-robot requested review from chaodaiG and yt3liu October 26, 2020 09:19

knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2020

knative-prow-robot assigned vaikas Oct 26, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020

knative-prow-robot merged commit 3ceaad4 into knative:master Oct 26, 2020

slinkydeveloper deleted the format_events_return_ordered_elements branch October 26, 2020 10:04

slinkydeveloper mentioned this pull request Oct 27, 2020

[0.17] Ported recent test infra improvements #4403

Merged

slinkydeveloper mentioned this pull request Oct 27, 2020

[0.18] Ported recent test infra improvements #4404

Merged

slinkydeveloper mentioned this pull request Oct 27, 2020

Port recordevents updates openshift/knative-eventing#917

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some nits in our test-infra I've found during a burning debugging session#4385

Some nits in our test-infra I've found during a burning debugging session#4385
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:format_events_return_ordered_elements

slinkydeveloper commented Oct 26, 2020

Uh oh!

codecov Bot commented Oct 26, 2020 •

edited

Loading

Uh oh!

vaikas commented Oct 26, 2020

Uh oh!

knative-prow-robot commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

slinkydeveloper commented Oct 26, 2020

Proposed Changes

Uh oh!

codecov Bot commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vaikas commented Oct 26, 2020

Uh oh!

knative-prow-robot commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 26, 2020 •

edited

Loading