This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Port recordevents updates#917
Merged
openshift-merge-robot merged 4 commits intoOct 28, 2020
Merged
Conversation
openshift-ci-robot
added
needs-rebase
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3ceaad4) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
* emit a k8s event when dropping events Signed-off-by: Ville Aikas <vaikas@vmware.com> * go imports Signed-off-by: Ville Aikas <vaikas@vmware.com> * tags Signed-off-by: Ville Aikas <vaikas@vmware.com> * fix silliness Signed-off-by: Ville Aikas <vaikas@vmware.com> * simplify Signed-off-by: Ville Aikas <vaikas@vmware.com> (cherry picked from commit 0a54fd9)
…l send (knative#4393) * Removed EventBroadcaster usage and replaced with manual creation and send of events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Boilerplate Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove redundant format Removed sequence annotation Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Added required value Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * ?!?! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Maybe this one fix the issue? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Removed useless double log line Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove useless headers Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing host header Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works on my machine, i'm warning you prow! Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now it works for long events too Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Suggestions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed the dropped counter thing Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 7de59ec) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
port_recordevents_updates
branch
from
72d5361 to
7bd1cc9
Compare
openshift-ci-robot
removed
the
needs-rebase
Member
|
/hold let's test this a few times |
openshift-ci-robot
added
the
do-not-merge/hold
Author
|
Green /retest |
Author
|
/test 46-e2e-aws-ocp-46 |
1 similar comment
Member
|
/test 46-e2e-aws-ocp-46 |
Member
|
/lgtm |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported: