emit a k8s event when dropping events

[vaikas]

Signed-off-by: Ville Aikas vaikas@vmware.com

When dropping events for test purposes, we did so silently. Emit an event for those that will not be counted towards tests because we change the type of the event to dropped-.

Proposed Changes

Release Note

Docs

[slinkydeveloper]

/assign

[codecov]

Codecov Report

Merging #4389 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4389   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files         285      285           
  Lines        8014     8014           
=======================================
  Hits         6500     6500           
  Misses       1128     1128           
  Partials      386      386           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0422b99...1c57141. Read the comment docs.

[vaikas]

    channel_single_event_helper.go:123: Timeout waiting for at least 1 matches.
        Error: FAIL MATCHING: saw 0/1 matching events.
        Recent events: 
        0 events seen, last 0 events (total events seen 8, events ignored 8):
        Match errors: 
        
        
        knative.dev/eventing/test/lib/recordevents.(*EventInfoStore).AssertAtLeast
        	/home/prow/go/src/knative.dev/eventing/test/lib/recordevents/event_info_store.go:163
        knative.dev/eventing/test/e2e/helpers.SingleEventForChannelTestHelper.func1
        	/home/prow/go/src/knative.dev/eventing/test/e2e/helpers/channel_single_event_helper.go:123
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:77
        testing.tRunner
        	/root/.gvm/gos/go1.14.10/src/testing/testing.go:1050
        runtime.goexit
        	/root/.gvm/gos/go1.14.10/src/runtime/asm_amd64.s:1373
    k8s_events.go:66: EventListener stopped, 13 events seen

This was running pre-upgrade tests (after installing 0.18.3), retrying it.
/test pull-knative-eventing-upgrade-tests

[slinkydeveloper]

/lgtm
/hold

Just a minor code style change, feel free to unhold if you like as is now

[vaikas]

@slinkydeveloper PTAL :) Cleaned up

[slinkydeveloper]

/lgtm
/approve
/unhold

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment