Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #6517


@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #6519 (e184075) into release-1.6 (e5adf30) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.6    #6519   +/-   ##
============================================
  Coverage        82.03%   82.03%           
============================================
  Files              235      235           
  Lines            11713    11713           
============================================
  Hits              9609     9609           
  Misses            1634     1634           
  Partials           470      470           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aliok
Copy link
Member

aliok commented Sep 8, 2022

/cherry-pick release-1.5

@knative-prow-robot
Copy link
Contributor Author

@aliok: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok
Copy link
Member

aliok commented Sep 8, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2022
@knative-prow knative-prow bot merged commit 922fc79 into knative:release-1.6 Sep 8, 2022
@knative-prow-robot
Copy link
Contributor Author

@aliok: new pull request could not be created: failed to create pull request against knative/eventing#release-1.5 from head knative-prow-robot:cherry-pick-6519-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between knative:release-1.5 and knative-prow-robot:cherry-pick-6519-to-release-1.5"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew pushed a commit to matzew/eventing that referenced this pull request Oct 26, 2022
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 26, 2022
* Make some broker conformance tests decoratable with broker options (knative#6519)

Co-authored-by: Ali Ok <aliok@redhat.com>

* [release-1.6] Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail Scheduler (knative#6527)

* Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail scheduler

Signed-off-by: aavarghese <avarghese@us.ibm.com>

* Adding tests - coverage for HA plugins not failing scheduler on zones/nodes with no schedulable pods

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Signed-off-by: aavarghese <avarghese@us.ibm.com>
Co-authored-by: aavarghese <avarghese@us.ibm.com>

* Add readiness and liveness probes in controller (knative#6567)

Co-authored-by: Lionel Villard <villard@us.ibm.com>

Signed-off-by: aavarghese <avarghese@us.ibm.com>
Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Ali Ok <aliok@redhat.com>
Co-authored-by: aavarghese <avarghese@us.ibm.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants