-
Notifications
You must be signed in to change notification settings - Fork 618
[release-1.6] Add readiness and liveness probes in controller #6567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.6] Add readiness and liveness probes in controller #6567
Conversation
Codecov ReportBase: 82.01% // Head: 82.01% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #6567 +/- ##
============================================
Coverage 82.01% 82.01%
============================================
Files 235 235
Lines 11706 11706
============================================
Hits 9601 9601
Misses 1636 1636
Partials 469 469 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/LGTM |
matzew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Lionel Villard <villard@us.ibm.com>
* Make some broker conformance tests decoratable with broker options (knative#6519) Co-authored-by: Ali Ok <aliok@redhat.com> * [release-1.6] Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail Scheduler (knative#6527) * Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail scheduler Signed-off-by: aavarghese <avarghese@us.ibm.com> * Adding tests - coverage for HA plugins not failing scheduler on zones/nodes with no schedulable pods Signed-off-by: aavarghese <avarghese@us.ibm.com> Signed-off-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: aavarghese <avarghese@us.ibm.com> * Add readiness and liveness probes in controller (knative#6567) Co-authored-by: Lionel Villard <villard@us.ibm.com> Signed-off-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Ali Ok <aliok@redhat.com> Co-authored-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: Lionel Villard <villard@us.ibm.com>
This is an automated cherry-pick of #6566