[release-1.6] Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail Scheduler #6527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en no pods available rather than fail scheduler Signed-off-by: aavarghese <avarghese@us.ibm.com>
…/nodes with no schedulable pods Signed-off-by: aavarghese <avarghese@us.ibm.com>
5 tasks
knative-prow
bot
added
the
size/L
Contributor
|
/cc @pierDipi |
Codecov ReportBase: 82.03% // Head: 82.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #6527 +/- ##
===============================================
- Coverage 82.03% 82.01% -0.02%
===============================================
Files 235 235
Lines 11713 11706 -7
===============================================
- Hits 9609 9601 -8
- Misses 1634 1636 +2
+ Partials 470 469 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pierDipi
approved these changes
Sep 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Member
|
/test upgrade-tests |
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Oct 26, 2022
…ew, requeue when no pods available rather than fail Scheduler (knative#6527) * Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail scheduler Signed-off-by: aavarghese <avarghese@us.ibm.com> * Adding tests - coverage for HA plugins not failing scheduler on zones/nodes with no schedulable pods Signed-off-by: aavarghese <avarghese@us.ibm.com> Signed-off-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: aavarghese <avarghese@us.ibm.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Oct 26, 2022
* Make some broker conformance tests decoratable with broker options (knative#6519) Co-authored-by: Ali Ok <aliok@redhat.com> * [release-1.6] Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail Scheduler (knative#6527) * Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail scheduler Signed-off-by: aavarghese <avarghese@us.ibm.com> * Adding tests - coverage for HA plugins not failing scheduler on zones/nodes with no schedulable pods Signed-off-by: aavarghese <avarghese@us.ibm.com> Signed-off-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: aavarghese <avarghese@us.ibm.com> * Add readiness and liveness probes in controller (knative#6567) Co-authored-by: Lionel Villard <villard@us.ibm.com> Signed-off-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Ali Ok <aliok@redhat.com> Co-authored-by: aavarghese <avarghese@us.ibm.com> Co-authored-by: Lionel Villard <villard@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6524