Move ResolveSubscriberSpec()#883
Merged
knative-prow-robot merged 7 commits intoMar 14, 2019
Merged
Conversation
… Eventing controllers using it.
… be used by multiple Controllers.
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/XXL
|
The following is the coverage report on pkg/.
|
Harwayne
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
matzew
reviewed
Mar 13, 2019
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Harwayne
added a commit
to Harwayne/knative-eventing
that referenced
this pull request
Mar 14, 2019
* Move the logging util out of contrib, in preparation for use by other Eventing controllers using it. * Thread through context. * Swap glog for zap.Logger in the Subscription reconciler. * Pass in the logger form main(). * Move ResolveSubscriberSpec out of Subscription Controller, as it will be used by multiple Controllers. * Fix bad merge of gcp-pubsub.
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Oct 15, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
creydr
pushed a commit
to creydr/knative-eventing
that referenced
this pull request
Oct 31, 2024
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #867.
Proposed Changes
Release Note