Create a mock dynamic client.#902
Merged
Merged
Conversation
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
approved
grantr
approved these changes
Mar 14, 2019
Contributor
grantr
left a comment
grantr
left a comment
There was a problem hiding this comment.
/lgtm
This seems like code that could have been generated... 🤔
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Realized this was unclear: I was intending to say that it would be nice if @Harwayne didn't have to write this by hand. |
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Oct 26, 2020
Go w/ 4 parallel
creydr
pushed a commit
to creydr/knative-eventing
that referenced
this pull request
Oct 31, 2024
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This functionality is needed for #788, after #883 got merged.
Release Note