Remove hacks/workarounds for bugs that are fixed in Istio 1.0.#1733
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 27, 2018
Merged
Remove hacks/workarounds for bugs that are fixed in Istio 1.0.#1733google-prow-robot merged 1 commit intoknative:masterfrom
google-prow-robot merged 1 commit intoknative:masterfrom
Conversation
google-prow-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
Contributor
Author
|
/test pull-knative-serving-integration-tests |
Contributor
|
This is really nice! |
Contributor
|
/lgtm |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akyyy, mattmoor, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
ZhiminXiang
pushed a commit
to ZhiminXiang/serving-1
that referenced
this pull request
Aug 2, 2018
tanzeeb
added a commit
to tanzeeb/serving
that referenced
this pull request
Aug 15, 2018
Was originally fixed in knative#1733, but accidentally reverted in knative#1689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #964
/assign @akyyy