Skip to content

Re-remove timeout hacks#1863

Closed
tanzeeb wants to merge 1 commit intoknative:masterfrom
tanzeeb:reremove-timeout-hacks
Closed

Re-remove timeout hacks#1863
tanzeeb wants to merge 1 commit intoknative:masterfrom
tanzeeb:reremove-timeout-hacks

Conversation

@tanzeeb
Copy link
Copy Markdown
Contributor

@tanzeeb tanzeeb commented Aug 15, 2018

Was originally fixed in #1733, but accidentally reverted in #1689

Was originally fixed in knative#1733, but accidentally reverted in knative#1689
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tanzeeb
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: josephburnett

If they are not already assigned, you can assign the PR to them by writing /assign @josephburnett in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanzeeb
Copy link
Copy Markdown
Contributor Author

tanzeeb commented Aug 20, 2018

Closing, duplicate of #1887

@tanzeeb tanzeeb closed this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants