Skip to content

Remove no longer needed workaround.#1887

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
tcnghia:remove-hacks
Aug 17, 2018
Merged

Remove no longer needed workaround.#1887
knative-prow-robot merged 1 commit into
knative:masterfrom
tcnghia:remove-hacks

Conversation

@tcnghia
Copy link
Copy Markdown
Contributor

@tcnghia tcnghia commented Aug 17, 2018

This has been removed in #1733, but accidentally put back in in #1689 .

@tcnghia tcnghia requested a review from josephburnett August 17, 2018 21:34
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2018
@josephburnett
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephburnett, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2018
@knative-prow-robot knative-prow-robot merged commit a8b6ec7 into knative:master Aug 17, 2018
@tanzeeb tanzeeb mentioned this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants