Fix mac errors for local server by RichieEscarez · Pull Request #233 · knative/website

RichieEscarez · 2020-10-24T03:22:41Z

Disable live reload for the Hugo server by default (LIVERELOAD=" --watch=false --disableLiveReload"). Docs get copied and fixed by the script so live reload is not useful for building only the docs. This also fixes the "too many files open" error in Macs when running the Hugo server.

Add option to enable live reload (ie for when modifying the site itself): localbuild.sh -s reload
For Macs, this will cause the "too many files open" error.

Updated the instructions.

RichieEscarez · 2020-10-28T17:58:42Z

+# disable Hugo server
+SERVER=""
+# disable live reload
+LIVERELOAD=" --watch=false --disableLiveReload"


primary change (1/3) - by default disable Hugo server live reload

RichieEscarez · 2020-10-28T17:59:11Z

-      echo 'Running hugo in server mode'
+      echo 'Running Hugo server'
      SERVER="server"
+      if [ "${OPTARG}" = "reload" ]; then


primary change (2/3) - if you use the "reload" flag, enable live reload in Hugo server

RichieEscarez · 2020-10-28T18:00:52Z

 # BUILD MARKDOWN
 # Start HUGO build
-hugo $SERVER --baseURL "" --environment "$BUILDENVIRONMENT"
+hugo $SERVER --baseURL "" --environment "$BUILDENVIRONMENT" $LIVERELOAD --gc


primary change (3/3) - also added --gc to clean cache each time (ie. using live reload is useful only for site updates) https://gohugo.io/commands/hugo_server/

RichieEscarez · 2020-11-09T23:53:57Z

@evankanderson or @mattmoor

If one of you get a free moment can you PTAL and help me merge this change? It's been working flawlessly for me over the last couple of weeks.

evankanderson

/lgtm
/approve

Sorry, I looked at this earlier but apparently forgot to comment.

knative-prow-robot · 2020-11-11T02:18:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [RichieEscarez,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* disable live reload and fix too many open files error (#233) * Add an update-codegen to regenerate the static redirects. (#239) * Add an update-codegen to regenerate the static redirects. Also fix a bug in redir-gen. * Add trailing newline * Fix missing continue * update docs build for 0.19 (#240) * Update DEVELOPMENT.md (#241) * Update DEVELOPMENT.md Document dependency on Hugo * Update DEVELOPMENT.md Point to docsy's recommended Hugo version. Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: RichieEscarez <rescarez@google.com> * Update build scripts to build from any named docs fork (#242) * make /community optional - default to knative repo * move webhook payload output to bottom of log * add logic to determine and use repo name of any fork * extract and use repo name from specified fork * Avoid Host key verification failed. Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>

…lds (#260) * disable live reload and fix too many open files error (#233) * Add an update-codegen to regenerate the static redirects. (#239) * Add an update-codegen to regenerate the static redirects. Also fix a bug in redir-gen. * Add trailing newline * Fix missing continue * update docs build for 0.19 (#240) * Update DEVELOPMENT.md (#241) * Update DEVELOPMENT.md Document dependency on Hugo * Update DEVELOPMENT.md Point to docsy's recommended Hugo version. Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: RichieEscarez <rescarez@google.com> * Update build scripts to build from any named docs fork (#242) * make /community optional - default to knative repo * move webhook payload output to bottom of log * add logic to determine and use repo name of any fork * extract and use repo name from specified fork * Avoid Host key verification failed. * Add net-ingressv2 golang redirect (#244) * Fix static HTML build (#245) dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)] * add version 0.20.0 to docs build (#247) * normal size nav text (#248) * Added control protocol redirect (#254) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * fix typo (#249) * add version 0.21.0 to docs build (#256) * add version 0.21.0 to docs build * trigger build * trigger build back * Redirect contributing URL to the docs website (#257) * Remove README->index renames (#259) * Add knative.dev/specs golang redirect (#258) * Add knative.dev/specs golang redirect * squash * search/replace master with main (#263) * Add Google Analytics tracking ID (#262) * new partial for adding 2nd GA id * force both IDs and ensure feedback buttons work * add: Redirects for various knative-sandbox plugin repos (#251) Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: Sameer Vohra <vohra.sam@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: tayarani <tayarani@users.noreply.github.com> Co-authored-by: Roland Huß <roland@ro14nd.de>

* disable live reload and fix too many open files error (#233) * Add an update-codegen to regenerate the static redirects. (#239) * Add an update-codegen to regenerate the static redirects. Also fix a bug in redir-gen. * Add trailing newline * Fix missing continue * update docs build for 0.19 (#240) * Update DEVELOPMENT.md (#241) * Update DEVELOPMENT.md Document dependency on Hugo * Update DEVELOPMENT.md Point to docsy's recommended Hugo version. Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: RichieEscarez <rescarez@google.com> * Update build scripts to build from any named docs fork (#242) * make /community optional - default to knative repo * move webhook payload output to bottom of log * add logic to determine and use repo name of any fork * extract and use repo name from specified fork * Avoid Host key verification failed. * Add net-ingressv2 golang redirect (#244) * Fix static HTML build (#245) dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)] * add version 0.20.0 to docs build (#247) * normal size nav text (#248) * Added control protocol redirect (#254) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * fix typo (#249) * add version 0.21.0 to docs build (#256) * add version 0.21.0 to docs build * trigger build * trigger build back * Redirect contributing URL to the docs website (#257) * Remove README->index renames (#259) * Add knative.dev/specs golang redirect (#258) * Add knative.dev/specs golang redirect * squash * search/replace master with main (#263) * Add Google Analytics tracking ID (#262) * new partial for adding 2nd GA id * force both IDs and ensure feedback buttons work * add: Redirects for various knative-sandbox plugin repos (#251) * Regenerate redirects to point at main (#265) * Run github.com/client9/misspell (#266) Signed-off-by: Knative Automation <automation@knative.team> * Fix/update missed release parameter (#261) * Add future Docs release owners as Approvers (#264) * Update development instructions with netlify info (#269) * Copy down notes from Slack * edits Co-authored-by: RichieEscarez <rescarez@google.com> * Update to latest version of Hugo from ~6 month old version (#270) * Resolved issue where files named "index.md" had incorrect file paths (#272) relative to local links * Add autogenerated imports (#274) Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: Sameer Vohra <vohra.sam@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: tayarani <tayarani@users.noreply.github.com> Co-authored-by: Roland Huß <roland@ro14nd.de> Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Mike Petersen <mike.petersen@ibm.com>

* disable live reload and fix too many open files error (#233) * Add an update-codegen to regenerate the static redirects. (#239) * Add an update-codegen to regenerate the static redirects. Also fix a bug in redir-gen. * Add trailing newline * Fix missing continue * update docs build for 0.19 (#240) * Update DEVELOPMENT.md (#241) * Update DEVELOPMENT.md Document dependency on Hugo * Update DEVELOPMENT.md Point to docsy's recommended Hugo version. Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: RichieEscarez <rescarez@google.com> * Update build scripts to build from any named docs fork (#242) * make /community optional - default to knative repo * move webhook payload output to bottom of log * add logic to determine and use repo name of any fork * extract and use repo name from specified fork * Avoid Host key verification failed. * Add net-ingressv2 golang redirect (#244) * Fix static HTML build (#245) dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)] * add version 0.20.0 to docs build (#247) * normal size nav text (#248) * Added control protocol redirect (#254) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * fix typo (#249) * add version 0.21.0 to docs build (#256) * add version 0.21.0 to docs build * trigger build * trigger build back * Redirect contributing URL to the docs website (#257) * Remove README->index renames (#259) * Add knative.dev/specs golang redirect (#258) * Add knative.dev/specs golang redirect * squash * search/replace master with main (#263) * Add Google Analytics tracking ID (#262) * new partial for adding 2nd GA id * force both IDs and ensure feedback buttons work * add: Redirects for various knative-sandbox plugin repos (#251) * Regenerate redirects to point at main (#265) * Run github.com/client9/misspell (#266) Signed-off-by: Knative Automation <automation@knative.team> * Fix/update missed release parameter (#261) * Add future Docs release owners as Approvers (#264) * Update development instructions with netlify info (#269) * Copy down notes from Slack * edits Co-authored-by: RichieEscarez <rescarez@google.com> * Update to latest version of Hugo from ~6 month old version (#270) * Resolved issue where files named "index.md" had incorrect file paths (#272) relative to local links * Add autogenerated imports (#274) * Bump y18n from 4.0.0 to 4.0.1 (#279) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update OWNERS_ALIASES to match autogen in community (#282) * add instructions for cutting a release (#284) * Fix spaces in command (#285) * Releasing 0.22 (#287) * Fixed spacing on code blocks (#289) * Don't build elections content into the website (#291) * Enable asciidoctor in Netlify builds (#292) * Enable asciidoctor in Netlify builds * Don't build elections content into the website * Update knative/community files (#277) Signed-off-by: Knative Automation <automation@knative.team> * Update knative/community files (#293) Signed-off-by: Knative Automation <automation@knative.team> * Redirect serving spec to specs repo (#290) * Enable new "help" section and fix a few things (#288) * new how to docs guides section * stop ignoring links in _index.md * add table formatting * move Dev instructions * update previous section name * revert table css * Remove golang module and build scripts from hugo build (#295) * Manually update from /community Copied from https://github.com/knative/community/blob/main/OWNERS_ALIASES Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: Sameer Vohra <vohra.sam@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: tayarani <tayarani@users.noreply.github.com> Co-authored-by: Roland Huß <roland@ro14nd.de> Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Mike Petersen <mike.petersen@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* disable live reload and fix too many open files error (#233) * Add an update-codegen to regenerate the static redirects. (#239) * Add an update-codegen to regenerate the static redirects. Also fix a bug in redir-gen. * Add trailing newline * Fix missing continue * update docs build for 0.19 (#240) * Update DEVELOPMENT.md (#241) * Update DEVELOPMENT.md Document dependency on Hugo * Update DEVELOPMENT.md Point to docsy's recommended Hugo version. Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: RichieEscarez <rescarez@google.com> * Update build scripts to build from any named docs fork (#242) * make /community optional - default to knative repo * move webhook payload output to bottom of log * add logic to determine and use repo name of any fork * extract and use repo name from specified fork * Avoid Host key verification failed. * Add net-ingressv2 golang redirect (#244) * Fix static HTML build (#245) dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)] * add version 0.20.0 to docs build (#247) * normal size nav text (#248) * Added control protocol redirect (#254) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * fix typo (#249) * add version 0.21.0 to docs build (#256) * add version 0.21.0 to docs build * trigger build * trigger build back * Redirect contributing URL to the docs website (#257) * Remove README->index renames (#259) * Add knative.dev/specs golang redirect (#258) * Add knative.dev/specs golang redirect * squash * search/replace master with main (#263) * Add Google Analytics tracking ID (#262) * new partial for adding 2nd GA id * force both IDs and ensure feedback buttons work * add: Redirects for various knative-sandbox plugin repos (#251) * Regenerate redirects to point at main (#265) * Run github.com/client9/misspell (#266) Signed-off-by: Knative Automation <automation@knative.team> * Fix/update missed release parameter (#261) * Add future Docs release owners as Approvers (#264) * Update development instructions with netlify info (#269) * Copy down notes from Slack * edits Co-authored-by: RichieEscarez <rescarez@google.com> * Update to latest version of Hugo from ~6 month old version (#270) * Resolved issue where files named "index.md" had incorrect file paths (#272) relative to local links * Add autogenerated imports (#274) * Bump y18n from 4.0.0 to 4.0.1 (#279) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update OWNERS_ALIASES to match autogen in community (#282) * add instructions for cutting a release (#284) * Fix spaces in command (#285) * Releasing 0.22 (#287) * Fixed spacing on code blocks (#289) * Don't build elections content into the website (#291) * Enable asciidoctor in Netlify builds (#292) * Enable asciidoctor in Netlify builds * Don't build elections content into the website * Update knative/community files (#277) Signed-off-by: Knative Automation <automation@knative.team> * Update knative/community files (#293) Signed-off-by: Knative Automation <automation@knative.team> * Redirect serving spec to specs repo (#290) * Enable new "help" section and fix a few things (#288) * new how to docs guides section * stop ignoring links in _index.md * add table formatting * move Dev instructions * update previous section name * revert table css * Remove golang module and build scripts from hugo build (#295) * Run github.com/client9/misspell (#298) Signed-off-by: Knative Automation <automation@knative.team> * Add knative-release-leads to OWNERS (#302) * upgrade to latest dependencies (#301) Signed-off-by: Knative Automation <automation@knative.team> * update website for v0.23 (#303) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update knative/community files (#300) Signed-off-by: Knative Automation <automation@knative.team> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: Sameer Vohra <vohra.sam@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: tayarani <tayarani@users.noreply.github.com> Co-authored-by: Roland Huß <roland@ro14nd.de> Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Mike Petersen <mike.petersen@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

RichieEscarez requested review from abrennan89 and evankanderson October 24, 2020 03:22

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 24, 2020

knative-prow-robot requested review from carieshmarie and samodell October 24, 2020 03:22

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2020

RichieEscarez requested review from mattmoor and removed request for samodell October 26, 2020 23:14

RichieEscarez commented Oct 28, 2020

View reviewed changes

disable live reload and fix too many open files error

e65005e

RichieEscarez force-pushed the fixmacerrors branch from 427a69b to e65005e Compare October 29, 2020 02:07

abrennan89 removed their request for review October 29, 2020 13:44

evankanderson reviewed Nov 11, 2020

View reviewed changes

knative-prow-robot assigned evankanderson Nov 11, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020

knative-prow-robot merged commit 92679e5 into knative:master Nov 11, 2020

RichieEscarez added a commit to RichieEscarez/website that referenced this pull request Mar 6, 2021

disable live reload and fix too many open files error (knative#233)

a3f46e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mac errors for local server#233

Fix mac errors for local server#233
knative-prow-robot merged 1 commit into
knative:masterfrom
RichieEscarez:fixmacerrors

RichieEscarez commented Oct 24, 2020 •

edited

Loading

Uh oh!

RichieEscarez Oct 28, 2020

Uh oh!

RichieEscarez Oct 28, 2020

Uh oh!

RichieEscarez Oct 28, 2020

Uh oh!

RichieEscarez commented Nov 9, 2020

Uh oh!

evankanderson left a comment

Uh oh!

knative-prow-robot commented Nov 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

RichieEscarez commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RichieEscarez Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

RichieEscarez Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

RichieEscarez Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

RichieEscarez commented Nov 9, 2020

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Nov 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RichieEscarez commented Oct 24, 2020 •

edited

Loading