Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Add an update-codegen to regenerate the static redirects.#239

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
evankanderson:the-machine
Nov 12, 2020
Merged

Add an update-codegen to regenerate the static redirects.#239
knative-prow-robot merged 3 commits into
knative:masterfrom
evankanderson:the-machine

Conversation

@evankanderson
Copy link
Copy Markdown
Member

@evankanderson evankanderson commented Nov 12, 2020

I also noticed a bug in redir-gen that we weren't going through list pagination, and so missed several repos.

/assign @mattmoor

I think adding ./hack/update-codegen.sh will cause nightly PRs to update when needed, but won't block other PRs with requiring this to be regenerated. Is that correct?

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 12, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2020
@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Nov 12, 2020

@evankanderson We probably need to add knative/website to repos.yaml in knative-sandbox/knobots for the daily PRs, I don't think it ever made the list.

For the verify-codegen presubmit check, the action sync should take care of that (once the actions land here) 🤞

mattmoor
mattmoor reviewed Nov 12, 2020
View reviewed changes
Comment thread tools/redir-gen/main.go
Comment on lines +83 to +85
if *r.Archived {
log.Print("Ignoring archived repo: ", *r.Name)
}
Copy link
Copy Markdown
Member

@mattmoor mattmoor Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why did Build show up 🤔

Copy link
Copy Markdown
Member

@mattmoor mattmoor Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! no continue

Copy link
Copy Markdown
Member Author

@evankanderson evankanderson Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, that'll teach me to refector without tests.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2020
@evankanderson evankanderson mentioned this pull request Nov 12, 2020
Closed
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Nov 12, 2020

I'm not sure we want a verify for these redirects, because they vary based on external factors (what repos have been created), and I'm not sure that we want to block PR submits because a new repo got created somewhere. Given that, I think just an update-codegen.sh is appropriate.

mattmoor
mattmoor approved these changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ec8357c into knative:master Nov 12, 2020
knative-prow-robot pushed a commit that referenced this pull request Dec 9, 2020
@RichieEscarez @xtreme-sameer-vohra
Keep the staging branch up-to-date (#243)
a08ff83 
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
RichieEscarez pushed a commit to RichieEscarez/website that referenced this pull request Mar 6, 2021
@RichieEscarez
Add an update-codegen to regenerate the static redirects. (knative#239)
8291f18 
* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue
knative-prow-robot pushed a commit that referenced this pull request Mar 16, 2021
@RichieEscarez @xtreme-sameer-vohra
@nak3 @slinkydeveloper @csantanapr @tayarani @rhuss
Sync Main and Staging branches -> sync "production" and "preview" bui…
b39a460 
…lds (#260)

* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
knative-prow-robot pushed a commit that referenced this pull request Mar 23, 2021
@RichieEscarez @xtreme-sameer-vohra
@nak3 @slinkydeveloper @csantanapr @tayarani @rhuss @markusthoemmes @knative-automation
Sync Staging to Main (#275)
69096e9 
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <automation@knative.team>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Mike Petersen <mike.petersen@ibm.com>
@evankanderson evankanderson deleted the the-machine branch March 23, 2021 23:23
knative-prow-robot pushed a commit that referenced this pull request May 11, 2021
@RichieEscarez @xtreme-sameer-vohra
@nak3 @slinkydeveloper @csantanapr @tayarani @rhuss @markusthoemmes @knative-automation @dependabot @abrennan89
Update the Staging branch (#297)
e952705 
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <automation@knative.team>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

* Bump y18n from 4.0.0 to 4.0.1 (#279)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OWNERS_ALIASES to match autogen in community (#282)

* add instructions for cutting a release (#284)

* Fix spaces in command (#285)

* Releasing 0.22 (#287)

* Fixed spacing on code blocks (#289)

* Don't build elections content into the website (#291)

* Enable asciidoctor in Netlify builds (#292)

* Enable asciidoctor in Netlify builds

* Don't build elections content into the website

* Update knative/community files (#277)

Signed-off-by: Knative Automation <automation@knative.team>

* Update knative/community files (#293)

Signed-off-by: Knative Automation <automation@knative.team>

* Redirect serving spec to specs repo (#290)

* Enable new "help" section and fix  a few things (#288)

* new how to docs guides section

* stop ignoring links in _index.md

* add table formatting

* move Dev instructions

* update previous section name

* revert table css

* Remove golang module and build scripts from hugo build (#295)

* Manually update from /community

Copied from https://github.com/knative/community/blob/main/OWNERS_ALIASES

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Mike Petersen <mike.petersen@ibm.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
knative-prow-robot pushed a commit that referenced this pull request May 20, 2021
@csantanapr @RichieEscarez
@xtreme-sameer-vohra @nak3 @slinkydeveloper @tayarani @rhuss @markusthoemmes @knative-automation @dependabot @abrennan89
sync main with v0.23 into staging (#304)
820cbd3 
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <automation@knative.team>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

* Bump y18n from 4.0.0 to 4.0.1 (#279)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OWNERS_ALIASES to match autogen in community (#282)

* add instructions for cutting a release (#284)

* Fix spaces in command (#285)

* Releasing 0.22 (#287)

* Fixed spacing on code blocks (#289)

* Don't build elections content into the website (#291)

* Enable asciidoctor in Netlify builds (#292)

* Enable asciidoctor in Netlify builds

* Don't build elections content into the website

* Update knative/community files (#277)

Signed-off-by: Knative Automation <automation@knative.team>

* Update knative/community files (#293)

Signed-off-by: Knative Automation <automation@knative.team>

* Redirect serving spec to specs repo (#290)

* Enable new "help" section and fix  a few things (#288)

* new how to docs guides section

* stop ignoring links in _index.md

* add table formatting

* move Dev instructions

* update previous section name

* revert table css

* Remove golang module and build scripts from hugo build (#295)

* Run github.com/client9/misspell (#298)

Signed-off-by: Knative Automation <automation@knative.team>

* Add knative-release-leads to OWNERS (#302)

* upgrade to latest dependencies (#301)

Signed-off-by: Knative Automation <automation@knative.team>

* update website for v0.23 (#303)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update knative/community files (#300)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Mike Petersen <mike.petersen@ibm.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

1 more reviewer

@mattmoor mattmoor mattmoor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evankanderson @mattmoor @knative-prow-robot