Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Add Google Analytics tracking ID#262

Merged
knative-prow-robot merged 2 commits into
knative:mainfrom
RichieEscarez:2ndGAid
Mar 10, 2021
Merged

Add Google Analytics tracking ID#262
knative-prow-robot merged 2 commits into
knative:mainfrom
RichieEscarez:2ndGAid

Conversation

@RichieEscarez
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez commented Mar 9, 2021

New partial and parameter that uses a copied version of the Hugo internal file used to add first ID.

Given the built in functionality in Hugo (for a single ID only) and to allow all the dependencies Hugo built in to continue working, the second ID is added using its own partial (a modified version of the same "built-in" internal GA feature).

Context:

fixes #253

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 9, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2021
@RichieEscarez RichieEscarez mentioned this pull request Mar 9, 2021
@RichieEscarez
Copy link
Copy Markdown
Contributor Author

RichieEscarez commented Mar 9, 2021

Note: Site builds are broken until #263 gets merged.

We wont be able to test and validate that this is working until then.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Mar 9, 2021

@RichieEscarez now that #263 has been merged, this is good to go? Just adding hold to make sure you can gatekeep if necessary :)
/hold
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2021
@RichieEscarez
Copy link
Copy Markdown
Contributor Author

Thanks @vaikas! We need #260 too before the PR builds will work (so that the staging branch picks up the branch name change too).

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@RichieEscarez RichieEscarez removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@RichieEscarez
Copy link
Copy Markdown
Contributor Author

Update: Looks like these knative/website originated builds are working in Netlify (the PR builds that originate from knative/docs are still broken re: #260).

@omerbensaadon This PR seems to be working. Both IDs show in the Preview build: https://deploy-preview-262--knative.netlify.app/.

Whats new/being added now to each page:

<script async="" src="https://www.googletagmanager.com/gtag/js?id=G-YRMNFYE32R"></script>
<script>
var doNotTrack = false;
if (!doNotTrack) {
  window.dataLayer = window.dataLayer || [];
  function gtag(){dataLayer.push(arguments);}
  gtag('js', new Date());
  gtag('config', 'G-YRMNFYE32R', { 'anonymize_ip': false });
}
</script>

@csantanapr
Copy link
Copy Markdown
Member

Nice !
/approve
/lgtm

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@knative-prow-robot knative-prow-robot merged commit 0dfbc9f into knative:main Mar 10, 2021
@RichieEscarez RichieEscarez deleted the 2ndGAid branch March 10, 2021 18:34
knative-prow-robot pushed a commit that referenced this pull request Mar 16, 2021
…lds (#260)

* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
knative-prow-robot pushed a commit that referenced this pull request Mar 23, 2021
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <automation@knative.team>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Mike Petersen <mike.petersen@ibm.com>
knative-prow-robot pushed a commit that referenced this pull request May 11, 2021
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <automation@knative.team>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

* Bump y18n from 4.0.0 to 4.0.1 (#279)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OWNERS_ALIASES to match autogen in community (#282)

* add instructions for cutting a release (#284)

* Fix spaces in command (#285)

* Releasing 0.22 (#287)

* Fixed spacing on code blocks (#289)

* Don't build elections content into the website (#291)

* Enable asciidoctor in Netlify builds (#292)

* Enable asciidoctor in Netlify builds

* Don't build elections content into the website

* Update knative/community files (#277)

Signed-off-by: Knative Automation <automation@knative.team>

* Update knative/community files (#293)

Signed-off-by: Knative Automation <automation@knative.team>

* Redirect serving spec to specs repo (#290)

* Enable new "help" section and fix  a few things (#288)

* new how to docs guides section

* stop ignoring links in _index.md

* add table formatting

* move Dev instructions

* update previous section name

* revert table css

* Remove golang module and build scripts from hugo build (#295)

* Manually update from /community

Copied from https://github.com/knative/community/blob/main/OWNERS_ALIASES

Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Mike Petersen <mike.petersen@ibm.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
knative-prow-robot pushed a commit that referenced this pull request May 20, 2021
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <rescarez@google.com>

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <automation@knative.team>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <rescarez@google.com>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

* Bump y18n from 4.0.0 to 4.0.1 (#279)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OWNERS_ALIASES to match autogen in community (#282)

* add instructions for cutting a release (#284)

* Fix spaces in command (#285)

* Releasing 0.22 (#287)

* Fixed spacing on code blocks (#289)

* Don't build elections content into the website (#291)

* Enable asciidoctor in Netlify builds (#292)

* Enable asciidoctor in Netlify builds

* Don't build elections content into the website

* Update knative/community files (#277)

Signed-off-by: Knative Automation <automation@knative.team>

* Update knative/community files (#293)

Signed-off-by: Knative Automation <automation@knative.team>

* Redirect serving spec to specs repo (#290)

* Enable new "help" section and fix  a few things (#288)

* new how to docs guides section

* stop ignoring links in _index.md

* add table formatting

* move Dev instructions

* update previous section name

* revert table css

* Remove golang module and build scripts from hugo build (#295)

* Run github.com/client9/misspell (#298)

Signed-off-by: Knative Automation <automation@knative.team>

* Add knative-release-leads to OWNERS (#302)

* upgrade to latest dependencies (#301)

Signed-off-by: Knative Automation <automation@knative.team>

* update website for v0.23 (#303)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update knative/community files (#300)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: Sameer Vohra <vohra.sam@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: tayarani <tayarani@users.noreply.github.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Mike Petersen <mike.petersen@ibm.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update /config/production/params.toml with community-owned search engine ID

5 participants