-
Notifications
You must be signed in to change notification settings - Fork 22
Merge develop to master #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add notes
Added effect of improving Makefile for local dev. A more traitional build approach. No longer _has_ to bind mount, etc.
Using docker ADD to invalidate pip install cache, will update if downloaded zips have changed. Also setting up volumes to persist android downloads between builds.
Dev Cache/Build Overhaul
Rather than relying on CLI output. To address issues where output is not as expected in docker.
Using cidfile option to store Container ID
…er-android into develop # Conflicts: # Dockerfile
Switch Kolibri server start to a separate persistent foreground service
…er-android into develop
Add arch argument to makefile.
For pipeline. Allows for manual whl specification
Add support for 64bit builds via docker and add to Buildkite pipeline
The scripts those vars trigger will no longer work, and will break the build if run.
Fix Automated Builds
Using LE_KOLIBRI_RELEASE envar to conditionalize trigger step.
Adding a few more explanatory comments
…uded in the release page.
Fix symlink issue and update blacklist after style guide changes.
App plugin
Add twisted manhole to provide remote provisioning/debugging shell
Set KOLIBRI_RUN_MODE based on signing key for APK (dev, testing, prod)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged, we can update https://buildkite.com/learningequality/kolibri-android-installer/settings/pipeline