3758 file pg preview#36
Merged
lubitchv merged 110 commits intolubitchv:3758-file-pg-previewfrom Oct 23, 2019
Merged
Conversation
…ible with recent ScribeJava library. Refactored code structure a bit, too.
…r base class to avoid code duplication when generating the user record.
…into 5991-oidc-provider
…xt". This is not usable on Glassfish 4.1. This reverts commit 55a2712.
The list of authorized scopes doesn't have to be in the same order as we send it. So better check the single scope names on their own. Relates to #5991.
Since the introduction of OAuth2 the scope attribute of all saved tokens has been "null", as there seemed to be a bug with ScribeJava. Upgrading from v3.3.6 to v6.8.1 resulted in exceptions due to the scope being saved now, but violating the 64 char limit. As the persisted data has not been in use ever since (the scope is always retrieved from the IdP implementation), the attribute has been removed to save database space and avoid the exception. An appropriate SQL migration script for Flyway has been added. Relates to #5991.
The GitHub auth provider had been implemented with no scope. Thus only public information is used, the user needs to provide his or her mail address on first login page. Relates to #5991.
Conflicts: src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
sleep after create and before publish of dv #6270
5991 - Update ScribeJava to 6.6.3 and necessary refactoring
and private url test
…-Ingest 6214 user notification following ingest
Correct being defined at http://guides.dataverse.org/en/4.17/developers/sql-upgrade-scripts.html#how-to-create-a-sql-upgrade-script "Use a version like "4.11.0.1" in the example above where the previously released version was 4.11, ensuring that the version number is unique. Note that this is not the version that you expect the code changes to be included in (4.12 in this example)."
use correct version in SQL upgrade script #6293
…ement 6266 api endpoints for token management
…empty-page 6258 cancel edit dataverse causes empty page
make the application build w/ PrimeFaces 7
add logging of MDC citation get URL and tweak docs #6137
Make MDC DataCite URl configurable
4286 metadata template preview fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.
Thanks for your contribution to Dataverse!
Related Issues
Pull Request Checklist