fix: private bucket

[pablohashescobar]

fix: private bucket

Summary by CodeRabbit

• New Features

  • Enhanced asset management capabilities for user avatars, covers, and project assets.
  • Added support for new entity types: DRAFT_ISSUE_ATTACHMENT and DRAFT_ISSUE_DESCRIPTION.
  • Introduced a new isDraft property for better differentiation in file uploads.

• Bug Fixes

  • Improved error handling in issue creation and updating processes.

• Documentation

  • Updated method signatures and property types to reflect new changes.

• Chores

  • Minor typo corrections for improved code clarity.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance asset management functionality across various endpoints, particularly focusing on user avatars, covers, workspace logos, and project covers. Key modifications include updates to method signatures for cache invalidation, improved asset deletion logic, file size limit checks, and the addition of new entity types. The migration introduces a new foreign key in the fileasset model and expands the entity_type options. Frontend components are updated to handle new properties related to draft issues, ensuring better integration with the backend changes.

Changes

File Path	Change Summary
apiserver/plane/app/views/asset/v2.py	Updated method signatures in UserAssetsV2Endpoint and WorkspaceFileAssetEndpoint to include request parameter; modified cache invalidation logic and asset deletion. Added file size limit check and streamlined entity type validation. Adjusted presigned URL generation and expanded get_entity_id_field in ProjectAssetEndpoint. Fixed typo in method name.
apiserver/plane/app/views/workspace/user.py	Updated filtering condition for attachment_count in WorkspaceUserProfileIssuesEndpoint.
apiserver/plane/db/migrations/0080_fileasset_draft_issue_alter_fileasset_entity_type.py	Added draft_issue foreign key to fileasset model and expanded entity_type options.
apiserver/plane/db/models/asset.py	Added DRAFT_ISSUE_ATTACHMENT and DRAFT_ISSUE_DESCRIPTION to EntityTypeContext; introduced draft_issue foreign key in FileAsset. Updated asset_url method.
packages/types/src/enums.ts	Added DRAFT_ISSUE_DESCRIPTION to EFileAssetType enum.
web/core/components/issues/issue-modal/base.tsx	Added activeProjectId variable; updated fetchIssueDetail and handleCreateIssue functions for better issue management and error handling.
web/core/components/issues/issue-modal/components/description-editor.tsx	Introduced isDraft property to TIssueDescriptionEditorProps; modified uploadFile method to differentiate between draft and regular issue descriptions.
web/core/components/issues/issue-modal/form.tsx	Added isDraft prop to IssueDescriptionEditor component; updated handleFormSubmit to manage is_draft property correctly.

Possibly related PRs

• feat: added external api endpoints for creating users and adding attachments to issues #5193: This PR adds an endpoint for creating issue attachments, which may relate to the asset management functionality enhanced in the main PR.
• feat: removed created_by from read_only serializer field, and ProjectMemberEndpoint updates #5260: This PR updates the IssueView to include new parameters for retrieving issues based on external identifiers, which aligns with the changes in the main PR regarding asset management and entity type handling.
• [WEB-2121] fix: project issue creation #5266: This PR modifies the createIssue method to include additional parameters for issue creation, which could be relevant to the changes made in the main PR regarding asset management and the handling of different entity types.
• [WEB-2388] fix: workspace draft issues #5800: This PR introduces changes to the DraftIssue serializers, which may relate to the new entity types and asset management functionalities introduced in the main PR.
• [WEB-2388] chore: theme changes and workspace draft issue total count updated #5805: This PR updates the total count of workspace draft issues, which could be relevant to the overall asset management improvements discussed in the main PR.

Suggested labels

🐛bug, ⚙️backend

Suggested reviewers

• rahulramesha
• sriramveeraghanta
• SatishGandham

Poem

In the meadow where assets play,
New features hop and dance all day.
With drafts and types, they find their way,
Caching clear, no delay!
A rabbit's cheer for changes bright,
Making management a pure delight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.