fix tests for https://github.com/matrix-org/synapse/pull/2090#350
Merged
Conversation
Contributor
|
LGTM |
Not sure why we need to have this twice.
richvdh
force-pushed
the
matthew/fix-filename-escaping
branch
from
65b1f3c to
5c1f1e7
Compare
Member
|
Again I've rewritten much of this so a re-review would be appreciated. It looks somewhat more complicated than it is. In a nutshell:
|
erikjohnston
approved these changes
Mar 5, 2019
| my $path = $parsed_uri->path; | ||
| # synapse uses filename* encoding for this, though regular filename encoding | ||
| # with a quoted string would be valid too | ||
| "name with spaces" => "inline; filename*=utf-8''name%20with%20spaces", |
Member
There was a problem hiding this comment.
It would be nice if this was a map of file names to a list of valid content dispositions, so we don't force synapse's choice on other projects
Member
There was a problem hiding this comment.
that's not quite as easy as it sounds. have made it parse the header.
Actually parse the header properly rather than checking it matches a hardcoded string.
erikjohnston
approved these changes
Mar 11, 2019
anoadragon453
added a commit
that referenced
this pull request
Mar 13, 2019
…server_specific_tests * 'develop' of github.com:matrix-org/sytest: (44 commits) test endpoint for updating backup versions (#559) Add test for transferring bans on a room upgrade (#563) fix tests for matrix-org/synapse#2090 (#350) Fix typo Fixup Incorporate review Remove prev_state from federation API Make the userdir synced not rely on being able to search for yourself (#567) Add basic soft fail test Check that event_id is given over state fetching over federation (#566) Fix registration rate limiting settings Fix comments Make sytest support auth rate limiting Fixup to not send 100 messages Test history visibility works for backfill Check that Server ACLs are preserved on room upgrade Better diagnostics from synapse startup (#561) Don't set PYTHONPATH when running synapse (#560) Regression test for redactions in room v3 (#558) Add test for PDU limit on transactions API (#555) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.