Add test for transferring bans on a room upgrade#563
Merged
Conversation
anoadragon453
force-pushed
the
anoa/bans_room_upgrade
branch
from
f86f30a to
956ea4a
Compare
erikjohnston
previously requested changes
Mar 7, 2019
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Looks good, apart from we can use helper functions and we should check in state section
|
|
||
| my $event = first { | ||
| $_->{type} eq "m.room.member" && $_->{state_key} eq '@bob:matrix.org', | ||
| } @{ $room->{timeline}->{events} }; |
Member
There was a problem hiding this comment.
We should probably check if its in the state section, as that's also a valid place.
On top of that, we can write this entire thing using await_sync_timeline_contains:
await_sync_timeline_contains( $user, $room, check => sub {
return unless $event->{type} eq "m.room.member";
return unless $event->{state_key} eq "@bob:matrix.org";
assert_deeply_eq(
$event->{content},
$content,
"ban in replacement room",
);
return 1;
});Which makes the test a lot shorter, and stops you from having to do the manual syncs.
We will have to create a new await_sync_timeline_or_state_contains function, but that is fairly trivial to do.
erikjohnston
reviewed
Mar 7, 2019
| return 1; | ||
| }); | ||
|
|
||
| Future->done(1); |
Member
There was a problem hiding this comment.
Remove this, as otherwise you're not using the result of await_sync_timeline_or_state_contains
Member
Author
There was a problem hiding this comment.
Ah lol. Happy to see that wasn't the reason it passed.
erikjohnston
approved these changes
Mar 11, 2019
anoadragon453
added a commit
that referenced
this pull request
Mar 13, 2019
…server_specific_tests * 'develop' of github.com:matrix-org/sytest: (44 commits) test endpoint for updating backup versions (#559) Add test for transferring bans on a room upgrade (#563) fix tests for matrix-org/synapse#2090 (#350) Fix typo Fixup Incorporate review Remove prev_state from federation API Make the userdir synced not rely on being able to search for yourself (#567) Add basic soft fail test Check that event_id is given over state fetching over federation (#566) Fix registration rate limiting settings Fix comments Make sytest support auth rate limiting Fixup to not send 100 messages Test history visibility works for backfill Check that Server ACLs are preserved on room upgrade Better diagnostics from synapse startup (#561) Don't set PYTHONPATH when running synapse (#560) Regression test for redactions in room v3 (#558) Add test for PDU limit on transactions API (#555) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synapse PR: matrix-org/synapse#4642