Skip to content

Make the userdir synced not rely on being able to search for yourself#567

Merged
hawkowl merged 12 commits into
developfrom
hawkowl/speed-userdir
Mar 7, 2019
Merged

Make the userdir synced not rely on being able to search for yourself#567
hawkowl merged 12 commits into
developfrom
hawkowl/speed-userdir

Conversation

@hawkowl
Copy link
Copy Markdown
Contributor

@hawkowl hawkowl commented Mar 1, 2019

No description provided.

@hawkowl hawkowl requested a review from a team March 1, 2019 08:13
richvdh
richvdh previously requested changes Mar 1, 2019
matrix_set_displayname( $user, $displayname )
->then( sub {
matrix_create_user_on_server( $user->http,
displayname => $searching_displayname
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing commas are nice

Comment thread tests/52user-directory/01public.pl Outdated
Comment thread tests/52user-directory/01public.pl Outdated
Comment thread tests/52user-directory/01public.pl Outdated
Comment thread tests/52user-directory/01public.pl Outdated
Comment thread tests/52user-directory/01public.pl Outdated
matrix_set_displayname( $user, $displayname )
->then( sub {

matrix_create_user_on_server( $user->http,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure why we are creating a user that is never used here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they have to join the room so that the dir is populated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't seem to join a room?

Comment thread tests/52user-directory/01public.pl Outdated
Comment thread tests/52user-directory/01public.pl Outdated
richvdh and others added 3 commits March 1, 2019 12:04
@richvdh richvdh self-requested a review March 4, 2019 10:08
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible other than the spare user

Comment thread tests/52user-directory/01public.pl Outdated
matrix_set_displayname( $user, $displayname )
->then( sub {

matrix_create_user_on_server( $user->http,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't seem to join a room?

@hawkowl hawkowl merged commit 709fc84 into develop Mar 7, 2019
@hawkowl hawkowl deleted the hawkowl/speed-userdir branch March 7, 2019 09:04
anoadragon453 added a commit that referenced this pull request Mar 13, 2019
…server_specific_tests

* 'develop' of github.com:matrix-org/sytest: (44 commits)
  test endpoint for updating backup versions (#559)
  Add test for transferring bans on a room upgrade (#563)
  fix tests for matrix-org/synapse#2090 (#350)
  Fix typo
  Fixup
  Incorporate review
  Remove prev_state from federation API
  Make the userdir synced not rely on being able to search for yourself (#567)
  Add basic soft fail test
  Check that event_id is given over state fetching over federation (#566)
  Fix registration rate limiting settings
  Fix comments
  Make sytest support auth rate limiting
  Fixup to not send 100 messages
  Test history visibility works for backfill
  Check that Server ACLs are preserved on room upgrade
  Better diagnostics from synapse startup (#561)
  Don't set PYTHONPATH when running synapse (#560)
  Regression test for redactions in room v3 (#558)
  Add test for PDU limit on transactions API (#555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants