simplifying the Zone group explanation for Local Zones OSDOCS-5240#3
Merged
maxwelldb merged 3 commits intomaxwelldb:aws-local-zones-existing-vpc-osdocs5240from Apr 28, 2023
Conversation
1 task
maxwelldb
reviewed
Apr 27, 2023
Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>
maxwelldb
reviewed
Apr 28, 2023
Owner
maxwelldb
left a comment
maxwelldb
left a comment
There was a problem hiding this comment.
A few quick notes and suggestions. Sorry to leave an incomplete first review--toddler business.
Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>
Author
no problem at all, we are in the same boat! =) I just sent a batch commit with your suggestions |
mtulio
changed the title
maxwelldb
pushed a commit
that referenced
this pull request
Jan 2, 2025
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
maxwelldb
pushed a commit
that referenced
this pull request
Feb 11, 2025
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
maxwelldb
pushed a commit
that referenced
this pull request
Feb 18, 2025
TELCODOCS-2036: Include Step 1. Configure virtual functions TELCODOCS-2036: Include Step 2. Configure the sriov operator with the Mellanox plugin disabled TELCODOCS-2036: Include Step 3. Check virtual functions after rebooting TELCODOCS-2036: Include Step 4. Eable secure boot TELCODOCS-2036: Dev feedback applied TELCODOCS-2036: '_mod-docs-content-type' commented out TELCODOCS-2036: Mellanox topic commented out TELCODOCS-2036: Mellanox topic reinstated TELCODOCS-2036: Some full stops addded TELCODOCS-2036: Dev feedback #2 applied TELCODOCS-2036: Dev feedback #3 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback openshift#5 applied TELCODOCS-2036: Peer review feedback applied TELCODOCS-2036: Repeating text removed TELCODOCS-2036: Peer review feedback #2 applied
maxwelldb
pushed a commit
that referenced
this pull request
Feb 18, 2025
TELCODOCS-2036: Include Step 1. Configure virtual functions TELCODOCS-2036: Include Step 2. Configure the sriov operator with the Mellanox plugin disabled TELCODOCS-2036: Include Step 3. Check virtual functions after rebooting TELCODOCS-2036: Include Step 4. Eable secure boot TELCODOCS-2036: Dev feedback applied TELCODOCS-2036: '_mod-docs-content-type' commented out TELCODOCS-2036: Mellanox topic commented out TELCODOCS-2036: Mellanox topic reinstated TELCODOCS-2036: Some full stops addded TELCODOCS-2036: Dev feedback #2 applied TELCODOCS-2036: Dev feedback #3 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback openshift#5 applied TELCODOCS-2036: Peer review feedback applied TELCODOCS-2036: Repeating text removed TELCODOCS-2036: Peer review feedback #2 applied
maxwelldb
pushed a commit
that referenced
this pull request
Jun 3, 2025
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
maxwelldb
pushed a commit
that referenced
this pull request
Jun 3, 2025
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
maxwelldb
pushed a commit
that referenced
this pull request
Jun 5, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
maxwelldb
pushed a commit
that referenced
this pull request
Jun 5, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
maxwelldb
pushed a commit
that referenced
this pull request
Aug 19, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
maxwelldb
pushed a commit
that referenced
this pull request
Aug 19, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
maxwelldb
pushed a commit
that referenced
this pull request
Aug 19, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
maxwelldb
pushed a commit
that referenced
this pull request
Aug 19, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
maxwelldb
pushed a commit
that referenced
this pull request
Aug 19, 2025
TELCODOCS-2153: Eroor with a new line in the table cell fixed TELCODOCS-2153: RHWA documentation link added TELCODOCS-2153: Dev feedback applied TELCODOCS-2153: Dev feedback #2 applied TELCODOCS-2153: Peer review squad feedback applied TELCODOCS-2153: Peer review squad feedback #2 applied TELCODOCS-2153: Peer review squad feedback #3 applied TELCODOCS-2153: Merge review feedback applied TELCODOCS-2153: Merge review feedback from Michael Burke applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s):
Issue:
Link to docs preview:
QE review:
Additional information:
Updates to PR openshift#57427