OSDOCS-5240 #57427: review rendered page with important fixes on the structure by mtulio · Pull Request #4 · maxwelldb/openshift-docs

mtulio · 2023-04-28T05:01:54Z

Review of openshift#57427:

Reordering sections
suggestions to review the file names
fixes identified from the preview page https://57427--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-localzone.html
adding module machine-edge-pool-review-nodes.adoc with a quick overview of the nodes after installation (helping user to understand what is delivered by the feature)
adding a helper page to deploy user workload on the "Next Steps"

Notes:

The fixes on CloudFormation and helpers present on 4.12 are super important to be backported, let's track it when we are ok with the final version of OSDOCS-5240

…s on the structure

maxwelldb

@mtulio Took a pass at this. LMK what you think.

maxwelldb · 2023-04-28T13:28:50Z

@mtulio Is there currently a ticket for backporting some content to 4.12?

Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>

mtulio · 2023-04-28T14:32:35Z

@mtulio Is there currently a ticket for backporting some content to 4.12?

No, AFAIK all have been closed. Let's focus on 4.13 review, than we will know what need to be adjusted on 4.12

maxwelldb · 2023-04-28T17:23:18Z

@mtulio Left a few more comments.

mtulio

overall LGTM

mtulio · 2023-04-28T17:33:51Z

@mtulio Left a few more comments.

that's fine for me to move on to the main stream

mtulio · 2023-04-28T17:34:02Z

thanks a lot! =)

Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>

maxwelldb · 2023-04-28T17:50:09Z

@mtulio Re-request review/DM/ping whenever you're okay with me merging this.

mtulio · 2023-04-28T17:53:51Z

@mtulio Re-request review/DM/ping whenever you're okay with me merging this.

@maxwelldb we can merge this one.
/lgtm

…figuring-Azure Enterprise #4.12 OADP-4454: Fixing configuration error in Azure installation docs

TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied

TELCODOCS-2036: Include Step 1. Configure virtual functions TELCODOCS-2036: Include Step 2. Configure the sriov operator with the Mellanox plugin disabled TELCODOCS-2036: Include Step 3. Check virtual functions after rebooting TELCODOCS-2036: Include Step 4. Eable secure boot TELCODOCS-2036: Dev feedback applied TELCODOCS-2036: '_mod-docs-content-type' commented out TELCODOCS-2036: Mellanox topic commented out TELCODOCS-2036: Mellanox topic reinstated TELCODOCS-2036: Some full stops addded TELCODOCS-2036: Dev feedback #2 applied TELCODOCS-2036: Dev feedback #3 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback openshift#5 applied TELCODOCS-2036: Peer review feedback applied TELCODOCS-2036: Repeating text removed TELCODOCS-2036: Peer review feedback #2 applied

TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied

mtulio force-pushed the PR-57427-local-zone-final-improvements branch from 8d9462d to b8761e6 Compare April 28, 2023 05:02

mtulio mentioned this pull request Apr 28, 2023

[OSDOCS-5240] Installer support to automatically create the MachineSets when installing in existing VPC on AWS w/Local Zones openshift/openshift-docs#57427

Merged

1 task

mtulio force-pushed the PR-57427-local-zone-final-improvements branch from b8761e6 to 2174705 Compare April 28, 2023 05:29

OSDOCS-5240 openshift#57427: review rendered page with important fixe…

2138067

…s on the structure

mtulio force-pushed the PR-57427-local-zone-final-improvements branch from 2174705 to 2138067 Compare April 28, 2023 05:51

mtulio commented Apr 28, 2023

View reviewed changes

Comment thread installing/installing_aws/installing-aws-localzone.adoc

mtulio commented Apr 28, 2023

View reviewed changes

Comment thread installing/installing_aws/installing-aws-localzone.adoc Outdated

mtulio commented Apr 28, 2023

View reviewed changes

Comment thread modules/edge-machine-pools-aws-local-zones.adoc

maxwelldb reviewed Apr 28, 2023

View reviewed changes

Apply suggestions from code review

c9c8482

Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>

mtulio closed this Apr 28, 2023

mtulio reopened this Apr 28, 2023

mtulio commented Apr 28, 2023

View reviewed changes

Apply suggestions from code review

8213595

Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>

maxwelldb merged commit f2db161 into maxwelldb:aws-local-zones-existing-vpc-osdocs5240 Apr 28, 2023

mtulio deleted the PR-57427-local-zone-final-improvements branch April 28, 2023 19:26

maxwelldb pushed a commit that referenced this pull request Sep 30, 2024

Merge pull request openshift#81910 from anarnold97/4.12-OADP-4454-Con…

87edb8a

…figuring-Azure Enterprise #4.12 OADP-4454: Fixing configuration error in Azure installation docs

Conversation

mtulio commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxwelldb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxwelldb commented Apr 28, 2023

Uh oh!

mtulio commented Apr 28, 2023

Uh oh!

maxwelldb commented Apr 28, 2023

Uh oh!

mtulio left a comment

Choose a reason for hiding this comment

Uh oh!

mtulio commented Apr 28, 2023

Uh oh!

mtulio commented Apr 28, 2023

Uh oh!

maxwelldb commented Apr 28, 2023

Uh oh!

mtulio commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mtulio commented Apr 28, 2023 •

edited

Loading

maxwelldb left a comment •

edited

Loading